fix: mlr3 1.0.0 compatibility (#242)

be-marc · pat-s · web-flow · commit 559519ddb35f · 2025-07-10T14:16:05.000+02:00
* compatibility: mlr3 1.0.0

* ...

* ...

* use r-lib/actions

* chore: use rspm

---------

Co-authored-by: pat-s &lt;patrick.schratz@gmail.com&gt;
diff --git a/.github/workflows/pkgdown.yaml b/.github/workflows/pkgdown.yaml
@@ -0,0 +1,53 @@
+# pkgdown workflow of the mlr3 ecosystem v0.1.0
+# https://github.com/mlr-org/actions
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+  release:
+    types:
+      - published
+  workflow_dispatch:
+
+name: pkgdown
+
+jobs:
+  pkgdown:
+    runs-on: ubuntu-latest
+
+    concurrency:
+      group: pkgdown-${{ github.event_name != 'pull_request' || github.run_id }}
+    env:
+      GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: r-lib/actions/setup-pandoc@v2
+
+      - uses: r-lib/actions/setup-r@v2
+        with:
+          use-public-rspm: true
+
+      - uses: r-lib/actions/setup-r-dependencies@v2
+        with:
+          extra-packages: any::pkgdown, local::.
+          needs: website
+
+      - name: Install template
+        run: pak::pkg_install("mlr-org/mlr3pkgdowntemplate")
+        shell: Rscript {0}
+
+      - name: Build site
+        run: pkgdown::build_site_github_pages(new_process = FALSE, install = FALSE)
+        shell: Rscript {0}
+
+      - name: Deploy
+        if: github.event_name != 'pull_request'
+        uses: JamesIves/github-pages-deploy-action@v4.7.3
+        with:
+          clean: false
+          branch: gh-pages
+          folder: docs
diff --git a/.github/workflows/r-cmd-check-old-paradox-new-other.yml b/.github/workflows/r-cmd-check-old-paradox-new-other.yml
@@ -38,6 +38,7 @@ jobs:
       - uses: r-lib/actions/setup-r@v2
         with:
           r-version: ${{ matrix.config.r }}
+          use-public-rspm: true
 
       - uses: r-lib/actions/setup-r-dependencies@v2
         with:
diff --git a/.github/workflows/r-cmd-check-paradox.yml b/.github/workflows/r-cmd-check-paradox.yml
@@ -38,6 +38,7 @@ jobs:
       - uses: r-lib/actions/setup-r@v2
         with:
           r-version: ${{ matrix.config.r }}
+          use-public-rspm: true
 
       - uses: r-lib/actions/setup-r-dependencies@v2
         with:
diff --git a/.github/workflows/r-cmd-check.yaml b/.github/workflows/r-cmd-check.yaml
@@ -0,0 +1,43 @@
+# r cmd check workflow of the mlr3 ecosystem v0.1.0
+# https://github.com/mlr-org/actions
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+name: r-cmd-check
+
+jobs:
+  r-cmd-check:
+    runs-on: ${{ matrix.config.os }}
+
+    name: ${{ matrix.config.os }} (${{ matrix.config.r }})
+
+    env:
+      GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
+
+    strategy:
+      fail-fast: false
+      matrix:
+        config:
+          - {os: ubuntu-latest,   r: 'devel'}
+          - {os: ubuntu-latest,   r: 'release'}
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: r-lib/actions/setup-r@v2
+        with:
+          r-version: ${{ matrix.config.r }}
+          use-public-rspm: true
+
+      - uses: r-lib/actions/setup-r-dependencies@v2
+        with:
+          extra-packages: any::rcmdcheck
+          needs: check
+
+      - uses: r-lib/actions/check-r-package@v2
diff --git a/.github/workflows/tic.yml b/.github/workflows/tic.yml
diff --git a/.github/workflows/update-tic.yml b/.github/workflows/update-tic.yml
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -2,7 +2,7 @@
 # R specific hooks: https://github.com/lorenzwalthert/precommit
 repos:
   - repo: https://github.com/lorenzwalthert/precommit
-    rev: v0.4.3.9003
+    rev: v0.4.3.9012
     hooks:
       - id: style-files
         args: [--style_pkg=styler.mlr, --style_fun=mlr_style]
diff --git a/R/ResamplingRepeatedSpCVBlock.R b/R/ResamplingRepeatedSpCVBlock.R
@@ -180,6 +180,7 @@ ResamplingRepeatedSpCVBlock = R6Class("ResamplingRepeatedSpCVBlock",
       self$instance = instance
       self$task_hash = task$hash
       self$task_nrow = task$nrow
+      self$task_row_hash = task$row_hash
       invisible(self)
     }
   ),
diff --git a/R/ResamplingRepeatedSpCVCoords.R b/R/ResamplingRepeatedSpCVCoords.R
@@ -89,6 +89,7 @@ ResamplingRepeatedSpCVCoords = R6Class("ResamplingRepeatedSpCVCoords",
       self$instance = instance
       self$task_hash = task$hash
       self$task_nrow = task$nrow
+      self$task_row_hash = task$row_hash
       invisible(self)
     }
   ),
diff --git a/R/ResamplingRepeatedSpCVDisc.R b/R/ResamplingRepeatedSpCVDisc.R
@@ -104,6 +104,7 @@ ResamplingRepeatedSpCVDisc = R6Class("ResamplingRepeatedSpCVDisc",
 
       self$task_hash = task$hash
       self$task_nrow = task$nrow
+      self$task_row_hash = task$row_hash
       invisible(self)
     }
   ),
diff --git a/R/ResamplingRepeatedSpCVEnv.R b/R/ResamplingRepeatedSpCVEnv.R
@@ -107,6 +107,7 @@ ResamplingRepeatedSpCVEnv = R6Class("ResamplingRepeatedSpCVEnv",
 
       self$instance = instance
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingRepeatedSpCVTiles.R b/R/ResamplingRepeatedSpCVTiles.R
@@ -134,6 +134,7 @@ ResamplingRepeatedSpCVTiles = R6Class("ResamplingRepeatedSpCVTiles",
       private$.sample(task$row_ids, task$coordinates())
 
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingRepeatedSpCVknndm.R b/R/ResamplingRepeatedSpCVknndm.R
@@ -133,6 +133,7 @@ ResamplingRepeatedSpCVKnndm = R6Class("ResamplingRepeatedSpCVKnndm",
 
       self$instance = instance
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingRepeatedSptCVCstf.R b/R/ResamplingRepeatedSptCVCstf.R
@@ -96,6 +96,7 @@ ResamplingRepeatedSptCVCstf = R6Class("ResamplingRepeatedSptCVCstf",
       self$instance = private$.sample(task)
 
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingSpCVBlock.R b/R/ResamplingSpCVBlock.R
@@ -139,6 +139,7 @@ ResamplingSpCVBlock = R6Class("ResamplingSpCVBlock",
 
       self$instance = instance
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingSpCVBuffer.R b/R/ResamplingSpCVBuffer.R
@@ -78,6 +78,7 @@ ResamplingSpCVBuffer = R6Class("ResamplingSpCVBuffer",
 
       self$instance = instance
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingSpCVCoords.R b/R/ResamplingSpCVCoords.R
@@ -64,6 +64,7 @@ ResamplingSpCVCoords = R6Class("ResamplingSpCVCoords",
 
       self$instance = instance
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingSpCVDisc.R b/R/ResamplingSpCVDisc.R
@@ -79,6 +79,7 @@ ResamplingSpCVDisc = R6Class("ResamplingSpCVDisc",
       private$.sample(task$row_ids, task$coordinates())
 
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingSpCVEnv.R b/R/ResamplingSpCVEnv.R
@@ -95,6 +95,7 @@ ResamplingSpCVEnv = R6Class("ResamplingSpCVEnv",
 
       self$instance = instance
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingSpCVKnndm.R b/R/ResamplingSpCVKnndm.R
@@ -131,6 +131,7 @@ ResamplingSpCVKnndm = R6Class("ResamplingSpCVKnndm",
 
       self$instance = instance
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingSpCVTiles.R b/R/ResamplingSpCVTiles.R
@@ -91,6 +91,7 @@ ResamplingSpCVTiles = R6Class("ResamplingSpCVTiles",
       private$.sample(task$row_ids, task$coordinates())
 
       self$task_hash = task$hash
+      self$task_row_hash = task$row_hash
       self$task_nrow = task$nrow
       invisible(self)
     }
diff --git a/R/ResamplingSptCVCstf.R b/R/ResamplingSptCVCstf.R
diff --git a/tests/testthat/test-1-autoplot.R b/tests/testthat/test-1-autoplot.R
diff --git a/tests/testthat/test-2-autoplot.R b/tests/testthat/test-2-autoplot.R
diff --git a/tests/testthat/test-autoplot_buffer.R b/tests/testthat/test-autoplot_buffer.R

Original file line number	Diff line number	Diff line change
`@@ -180,6 +180,7 @@ ResamplingRepeatedSpCVBlock = R6Class("ResamplingRepeatedSpCVBlock",`
`180`	`180`	`self$instance = instance`
`181`	`181`	`self$task_hash = task$hash`
`182`	`182`	`self$task_nrow = task$nrow`
	`183`	`+ self$task_row_hash = task$row_hash`
`183`	`184`	`invisible(self)`
`184`	`185`	`}`
`185`	`186`	`),`
Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ ResamplingRepeatedSpCVCoords = R6Class("ResamplingRepeatedSpCVCoords",`
`89`	`89`	`self$instance = instance`
`90`	`90`	`self$task_hash = task$hash`
`91`	`91`	`self$task_nrow = task$nrow`
	`92`	`+ self$task_row_hash = task$row_hash`
`92`	`93`	`invisible(self)`
`93`	`94`	`}`
`94`	`95`	`),`
Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,7 @@ ResamplingRepeatedSpCVDisc = R6Class("ResamplingRepeatedSpCVDisc",`
`104`	`104`
`105`	`105`	`self$task_hash = task$hash`
`106`	`106`	`self$task_nrow = task$nrow`
	`107`	`+ self$task_row_hash = task$row_hash`
`107`	`108`	`invisible(self)`
`108`	`109`	`}`
`109`	`110`	`),`