Skip to content

Conversation

@ZNeumann
Copy link
Contributor

@ZNeumann ZNeumann commented May 30, 2025

Some transaction globals were leaked when calling newrelic_end_transaction(true). The freeing of these transaction globals has been moved to join all the other transaction globals to alleviate this.

In so doing, additional rshutdown methods are needed. This is because the transaction globals contain reference incremented zvals. If we wait until postdeactivate, those zvals will be in an undefined state and the data structures containing those references cannot be properly freed. In line with other transaction globals, we trigger a shutdown method during rshutdown to free these globals while the zvals are still valid.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented May 30, 2025

Test Suite Status Result
Multiverse 15/16 passing
SOAK 83/85 passing

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.15%. Comparing base (469e63e) to head (d90b538).
⚠️ Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1072      +/-   ##
==========================================
+ Coverage   78.13%   78.15%   +0.01%     
==========================================
  Files         193      193              
  Lines       28045    28053       +8     
==========================================
+ Hits        21914    21925      +11     
+ Misses       6131     6128       -3     
Flag Coverage Δ
agent-for-php-7.2 78.40% <100.00%> (+0.01%) ⬆️
agent-for-php-7.3 78.42% <100.00%> (+0.01%) ⬆️
agent-for-php-7.4 78.28% <100.00%> (+0.01%) ⬆️
agent-for-php-8.0 77.48% <100.00%> (+0.01%) ⬆️
agent-for-php-8.1 77.79% <100.00%> (+0.01%) ⬆️
agent-for-php-8.2 77.41% <100.00%> (+0.01%) ⬆️
agent-for-php-8.3 77.41% <100.00%> (+0.01%) ⬆️
agent-for-php-8.4 77.43% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZNeumann ZNeumann force-pushed the zjn/valgrind branch 2 times, most recently from 5deff4d to e953a97 Compare June 16, 2025 15:05
@ZNeumann ZNeumann changed the base branch from zjn/valgrind to dev June 18, 2025 11:58
@ZNeumann ZNeumann marked this pull request as ready for review June 18, 2025 12:21
@zsistla zsistla added this to the next-release milestone Aug 11, 2025
@ZNeumann ZNeumann merged commit 5d16756 into dev Sep 5, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants