Skip to content

Commit e7a52b9

Browse files
committed
Merge branch 'issue-7881-stickyheader-with-dialog-actions' into develop
2 parents 31d07b6 + b2d9304 commit e7a52b9

File tree

9 files changed

+30
-23
lines changed

9 files changed

+30
-23
lines changed

src/Plugins/Nop.Plugin.Misc.RFQ/Views/Admin/AdminQuotes.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<i class="fas fa-plus-square"></i>
2727
@T("Plugins.Misc.RFQ.CreateNew")
2828
</button>
29-
<button type="button" id="delete-selected" name="delete-selected" class="btn btn-danger">
29+
<button type="button" id="delete-selected" class="btn btn-danger">
3030
<i class="far fa-trash-alt"></i>
3131
@T("Plugins.Misc.RFQ.DeleteSelected")
3232
</button>

src/Plugins/Nop.Plugin.Misc.RFQ/Views/Admin/AdminRequests.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
@T("Plugins.Misc.RFQ.RequestsQuote")
2222
</h1>
2323
<div class="float-right">
24-
<button type="button" id="delete-selected" name="delete-selected" class="btn btn-danger">
24+
<button type="button" id="delete-selected" class="btn btn-danger">
2525
<i class="far fa-trash-alt"></i>
2626
@T("Plugins.Misc.RFQ.DeleteSelected")
2727
</button>

src/Presentation/Nop.Web.Framework/Models/ActionConfirmationModel.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ public partial class ActionConfirmationModel
1919
/// </summary>
2020
public string WindowId { get; set; }
2121
/// <summary>
22+
/// Button ID
23+
/// </summary>
24+
public string ButtonId { get; set; }
25+
/// <summary>
2226
/// Additionl confirm text
2327
/// </summary>
2428
public string AdditonalConfirmText { get; set; }

src/Presentation/Nop.Web.Framework/TagHelpers/Admin/NopActionConfirmationTagHelper.cs

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ public override async Task ProcessAsync(TagHelperContext context, TagHelperOutpu
6464
ControllerName = _htmlHelper.ViewContext.RouteData.Values["controller"].ToString(),
6565
ActionName = Action,
6666
WindowId = modalId,
67+
ButtonId = ButtonId,
6768
AdditonalConfirmText = ConfirmText
6869
};
6970

@@ -79,18 +80,6 @@ public override async Task ProcessAsync(TagHelperContext context, TagHelperOutpu
7980

8081
var partialView = await _htmlHelper.PartialAsync("Confirm", actionConfirmationModel);
8182
output.Content.SetHtmlContent(partialView);
82-
83-
//modal script
84-
var script = new TagBuilder("script");
85-
script.InnerHtml.AppendHtml(
86-
"$(function() {" +
87-
$"$('#{ButtonId}').attr(\"data-toggle\", \"modal\").attr(\"data-target\", \"#{modalId}\");" +
88-
$"$('#{modalId}-submit-button').attr(\"name\", $(\"#{ButtonId}\").attr(\"name\"));" +
89-
$"$(\"#{ButtonId}\").attr(\"name\", \"\");" +
90-
$"if($(\"#{ButtonId}\").attr(\"type\") == \"submit\")$(\"#{ButtonId}\").attr(\"type\", \"button\");" +
91-
"});");
92-
var scriptTag = await script.RenderHtmlContentAsync();
93-
output.PostContent.SetHtmlContent(scriptTag);
9483
}
9584

9685
#endregion

src/Presentation/Nop.Web/Areas/Admin/Views/Log/List.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
@T("Admin.System.Log")
1919
</h1>
2020
<div class="float-right">
21-
<button type="button" id="delete-selected" name="delete-selected" class="btn btn-danger">
21+
<button type="button" id="delete-selected" class="btn btn-danger">
2222
<i class="far fa-trash-can"></i>
2323
@T("Admin.System.Log.DeleteSelected")
2424
</button>

src/Presentation/Nop.Web/Areas/Admin/Views/Order/AddShipment.cshtml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,17 +111,13 @@
111111
$("#shipment-save-action-confirmation").remove();
112112
$(this).attr("name", "save").attr("type", "submit");
113113
}
114-
}).on("click", function () {
115-
return validateWarehouseAvailability("save");
116114
});
117115
118116
$("#shipment-save-continue").on("focus", function () {
119117
if (validateWarehouseAvailability("continue")) {
120118
$("#shipment-save-continue-action-confirmation").remove();
121119
$(this).attr("name", "save-continue").attr("type", "submit");
122120
}
123-
}).on("click", function () {
124-
return validateWarehouseAvailability("continue");
125121
});
126122
});
127123

src/Presentation/Nop.Web/Areas/Admin/Views/Product/BulkEdit.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
</small>
2525
</h1>
2626
<div class="float-right">
27-
<button type="submit" id="bulk-edit-save-selected" name="bulk-edit-save-selected" class="btn btn-primary">
27+
<button type="submit" id="bulk-edit-save-selected" class="btn btn-primary">
2828
<i class="far fa-save"></i>
2929
@T("Admin.Catalog.Products.BulkEdit.SaveSelected")
3030
</button>

src/Presentation/Nop.Web/Areas/Admin/Views/QueuedEmail/List.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@
249249
});
250250
251251
//"requeue selected" button
252-
$("#requeue-selected-action-confirmation").on("click", function () {
252+
$("#requeue-selected-action-confirmation-submit-button").on("click", function () {
253253
var postData = {
254254
selectedIds: selectedIds
255255
};

src/Presentation/Nop.Web/Areas/Admin/Views/Shared/Confirm.cshtml

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,28 @@
1616
@T("Admin.Common.ActionConfirmation")
1717
</div>
1818
<div class="modal-footer">
19-
<button type="submit" id="@(Model.WindowId)-submit-button" class="btn btn-primary float-right">
19+
<button type="button" id="@(Model.WindowId)-submit-button" class="btn btn-primary float-right">
2020
@T("Admin.Common.Yes")
2121
</button>
2222
<span class="btn btn-default float-right margin-r-5" data-dismiss="modal">@T("Admin.Common.NoCancel")</span>
2323
</div>
2424
</div>
25-
</div>
25+
</div>
26+
27+
<script>
28+
$(function(){
29+
const openerBtn = document.getElementById('@Model.ButtonId');
30+
31+
openerBtn.type = "button";
32+
openerBtn.setAttribute("data-toggle", "modal");
33+
openerBtn.setAttribute("data-target", "#@Model.WindowId")
34+
35+
$('#@(Model.WindowId)-submit-button').on('click', function() {
36+
if (!openerBtn.name)
37+
return;
38+
39+
openerBtn.type = "submit";
40+
openerBtn.click();
41+
});
42+
});
43+
</script>

0 commit comments

Comments
 (0)