Skip to content

Commit 3ce8e6d

Browse files
committed
Revert "CI: Workaround duplicated release creation"
This reverts commit d1cdd60 until I figured out why it doesn't find the release in the second attempt.
1 parent 56e8a62 commit 3ce8e6d

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

lib/ruby_installer/build/release.rb

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -105,17 +105,7 @@ def upload_to_github(tag:, repo:, token: nil, files:)
105105
)
106106
end
107107

108-
# Recheck all releases to avoid duplicated release creation
109-
release2 = nil
110-
(1..100).find do |page|
111-
release2 = client.releases(repo, page: page).find{|r| r.tag_name==tag }
112-
end
113-
# Did we create a second release in parallel?
114-
if release.id != release2.id
115-
client.delete_release(release.url)
116-
end
117-
118-
old_assets = client.release_assets(release2.url)
108+
old_assets = client.release_assets(release.url)
119109

120110
files.each do |fname|
121111
if old_asset=old_assets.find{|a| a.name == File.basename(fname) }
@@ -124,7 +114,7 @@ def upload_to_github(tag:, repo:, token: nil, files:)
124114
end
125115

126116
$stderr.print "Uploading #{fname} (#{File.size(fname)} bytes) ... "
127-
client.upload_asset(release2.url, fname, content_type: CONTENT_TYPE_FOR_EXT[File.extname(fname)])
117+
client.upload_asset(release.url, fname, content_type: CONTENT_TYPE_FOR_EXT[File.extname(fname)])
128118
$stderr.puts "OK"
129119
end
130120
end

0 commit comments

Comments
 (0)