Handle race between calling jfr RecordingStream.start() and close() (#15231)

Author: laurit

instrumentation/runtime-telemetry/runtime-telemetry-java17/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java17/RuntimeMetrics.java

@@ -89,6 +89,7 @@ static class JfrRuntimeMetrics implements Closeable {
     private final List<RecordedEventHandler> recordedEventHandlers;
     private final RecordingStream recordingStream;
     private final CountDownLatch startUpLatch = new CountDownLatch(1);
+    private volatile boolean closed = false;
 
     private JfrRuntimeMetrics(OpenTelemetry openTelemetry, Predicate<JfrFeature> featurePredicate) {
       this.recordedEventHandlers = HandlerRegistry.getHandlers(openTelemetry, featurePredicate);
@@ -101,12 +102,28 @@ private JfrRuntimeMetrics(OpenTelemetry openTelemetry, Predicate<JfrFeature> fea
             recordingStream.onEvent(handler.getEventName(), handler);
           });
       recordingStream.onMetadata(event -> startUpLatch.countDown());
-      Thread daemonRunner = new Thread(recordingStream::start, "OpenTelemetry JFR-Metrics-Runner");
+      Thread daemonRunner =
+          new Thread(this::startRecordingStream, "OpenTelemetry JFR-Metrics-Runner");
       daemonRunner.setDaemon(true);
       daemonRunner.setContextClassLoader(null);
       daemonRunner.start();
     }
 
+    private void startRecordingStream() {
+      if (closed) {
+        return;
+      }
+
+      try {
+        recordingStream.start();
+      } catch (IllegalStateException exception) {
+        // Can happen when close is called at the same time as start
+        if (!closed) {
+          throw exception;
+        }
+      }
+    }
+
     static JfrRuntimeMetrics build(
         OpenTelemetry openTelemetry, Predicate<JfrFeature> featurePredicate) {
       if (!isJfrAvailable()) {
@@ -117,6 +134,7 @@ static JfrRuntimeMetrics build(
 
     @Override
     public void close() {
+      closed = true;
       recordingStream.close();
       recordedEventHandlers.forEach(RecordedEventHandler::close);
     }