feat: Match QFDMO with the categories taxonomy to make it possible to give customized and local circular advice in France #12581
Conversation
github-project-automation
bot
moved this to To discuss and validate
in 🍊 Open Food Facts Server issues
github-actions
bot
added
🧬 Taxonomies
|
@copilot can you add properties qfdmo_name_fr: and identifiant_qfdmo: from taxonomies/product/qfdmo_additional_categories.txt into taxonomies/product/categories.txt on exact match on one of the fr: synonyms ? |
…matching (#12582) Enriches the product categories taxonomy with QFDMO (Où et comment donner, réparer et recycler) metadata by matching French category names between `qfdmo_additional_categories.txt` and `categories.txt`. ## Changes - Matched 487 category entries by exact French synonym matching (comma-separated `fr:` values) - Added `qfdmo_name_fr:` property (QFDMO code identifier) to all matched entries - Added `identifiant_qfdmo:` property (numeric ID) to 165 entries where available - Properties inserted immediately after `fr:` line to maintain taxonomy formatting conventions ## Example ``` fr: Niches pour chiens, Niche qfdmo_name_fr: niche identifiant_qfdmo: 442 it: Casette per cani ``` Coverage spans clothing, electronics, toys, sports equipment, furniture, and medical supplies. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: teolemon <[email protected]>
|
/lint |
ProblemCan you create a knowledge panel in the Reuse section (like the Health or Environment section) on Open Products Facts, for products with a category that has a qfdmo_name_fr: property, only if the panel is requested with the cc parameter: fr PointersYou can also use as inspiration those 2 pull requests for Alcohol |
|
@copilot can you fix the position of qfdmo_name_fr: and identifiant_qfdmo: to be after all the languages lines of the entry they are in ? |
QFDMO properties (`qfdmo_name_fr:` and `identifiant_qfdmo:`) were incorrectly positioned immediately after the `fr:` line, causing them to appear before other language translations. ### Changes - Repositioned QFDMO properties to follow all language lines (en:, fr:, de:, es:, it:, ja:, nl:, etc.) but precede other metadata properties (google_product_taxonomy_id:en:, wikidata:en:) - Affected 487 taxonomy entries ### Example **Before:** ``` fr: Jeux de plateau, Jeux de société, Jeu de société qfdmo_name_fr: jeu_de_societe identifiant_qfdmo: 194 it: Giochi in scatola ja: ボードゲーム nl: Bordspellen ``` **After:** ``` fr: Jeux de plateau, Jeux de société, Jeu de société it: Giochi in scatola ja: ボードゲーム nl: Bordspellen qfdmo_name_fr: jeu_de_societe identifiant_qfdmo: 194 ``` <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: teolemon <[email protected]>
|
/lint |
|
ERROR - duplicate_synonym - 13890 - fr:manteau already is a synonym of fr:manteaux-et-vestes for entry en:coats-jackets (categories) - fr:manteau cannot be mapped to entry en:coat / fr:manteau |
teolemon
changed the title
teolemon
changed the title
|
@copilot can you make a PR to try to fix this ? ERROR - duplicate_synonym - 13890 - fr:manteau already is a synonym of fr:manteaux-et-vestes for entry en:coats-jackets (categories) - fr:manteau cannot be mapped to entry en:coat / fr:manteau Originally posted by @teolemon in #12581 (comment) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12581 +/- ##
==========================================
+ Coverage 46.40% 51.77% +5.37%
==========================================
Files 95 96 +1
Lines 24728 24786 +58
Branches 5922 5931 +9
==========================================
+ Hits 11474 12832 +1358
+ Misses 11700 10236 -1464
- Partials 1554 1718 +164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Updated QFDMO property formatting in the categories taxonomy to use consistent naming conventions and value formats. ### Changes - **Property name**: Renamed `qfdmo_name_fr:` to `qfdmo_name:fr:` (487 entries) - Aligns with standard language-qualified property format (e.g., `property:language:`) - **Value normalization**: Replaced underscores with hyphens in all QFDMO name values - Example: `qfdmo_name_fr: mobilier_animalier` → `qfdmo_name:fr: mobilier-animalier` - Maintains consistency with taxonomy identifier conventions ### Example ```diff en: Pet Furniture fr: Mobilier animalier -qfdmo_name_fr: mobilier_animalier +qfdmo_name:fr: mobilier-animalier ``` <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/openfoodfacts/openfoodfacts-server/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: teolemon <[email protected]>
|
/lint |
|
/lint |
|
/lint |
| @@ -21874,9 +22348,18 @@ pt: Acessórios para eletrônicos | |||
| ru: Принадлежности для электроники | |||
| sv: Elektroniktillbehör | |||
| tr: Elektronik Alet Aksesuarları | |||
| qfdmo_name:fr: accessoire-automobile-et-deux-roues-electronique | |||
|
/lint |
|
/lint |
|
|
/lint |
What