-
-
Notifications
You must be signed in to change notification settings - Fork 36
fix: remove bogus heights in content pages #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stephanegigandet
wants to merge
1
commit into
main
Choose a base branch
from
remove-bogus-heights
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,3 @@ | ||
| <div id="main_column" class="xxlarge-11 xlarge-10 large-9 medium-8 columns" style="padding-top: 1rem; height: 3993px;" data-equalizer-watch=""> | ||
|
|
||
| <!-- main column content - comment used to remove left column and center content on some pages --> | ||
| <h1 class="emphasized-title">Nova groups for food processing</h1> | ||
|
|
||
| <h2 class="emphasized-title">A classification in 4 groups to highlight the degree of processing of foods</h2> | ||
|
|
@@ -73,4 +70,3 @@ <h2 class="emphasized-title">Frequently Asked Questions</h2> | |
| <a href="https://support.openfoodfacts.org/help/en-gb/6">We have listed the Frequently Asked Questions about NOVA here</a><br> | ||
| Feel free to ask additional questions at <a href="mailto:[email protected]?subject=Question%20about%20the%20Nova%20Groups&body=Source%3A%20the%20NOVA%20methodology%20explainer%20page">[email protected]</a> | ||
|
|
||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,3 @@ | ||
| <div id="main_column" class="xxlarge-11 xlarge-10 large-9 medium-8 columns" style="padding-top: 1rem; height: 3993px;" data-equalizer-watch=""> | ||
|
|
||
| <!-- main column content - comment used to remove left column and center content on some pages --> | ||
| <h1 class="emphasized-title">Classification NOVA pour la transformation des aliments</h1> | ||
|
|
||
| <h2 class="emphasized-title">Une classification en 4 groupes pour mettre en évidence le degré de transformation des aliments</h2> | ||
|
|
@@ -71,5 +68,3 @@ <h4>Ingrédients et catégories trouvés seulement dans le groupe 4</h4> | |
| <h2 class="emphasized-title">Foire Aux Questions</h2> | ||
|
|
||
| <a href="https://support.openfoodfacts.org/help/en-gb/6"> Nous avons listées les questions fréquemment posées au sujet de NOVA ici </a> <br> N'hésitez pas à poser des questions à cette adresse : <a href="mailto:[email protected]?subject=Question%20about%20the%20Nova%20Groups&body=Source%3A%20the%20NOVA%20methodology%20explainer%20page">[email protected]</a> | ||
|
|
||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,3 @@ | ||
| <div id="main_column" class="xxlarge-11 xlarge-10 large-9 medium-8 columns" style="padding-top:1rem;height:11489px" data-equalizer-watch=""> | ||
|
|
||
| <!-- main column content - comment used to remove left column and center content on some pages --> | ||
|
|
||
|
|
||
|
|
||
| <h1>Guide pour les producteurs</h1> | ||
|
|
||
| <p>Ce guide explique pourquoi et comment les producteurs peuvent directement intégrer des photos et des données de produit dans la base de données Open Food Facts en utilisant notre plateforme.</p> | ||
|
|
@@ -239,28 +233,3 @@ <h3 id="est_il_possible_de_supprimer_les_produits_qui_ne_sont_plus_vendus">Est-i | |
|
|
||
| <h3 id="est_ce_que_les_produits_pour_animaux_les_produits_non_alimentaires_les_cosmetiques_et_les_autres_produits_peuvent_etre_integres_a_open_food_facts">Les produits d'origine animale, les produits non alimentaires, les cosmétiques et d'autres produits peuvent-ils être intégrés dans Open Food Facts ?</h3> | ||
| <p>Nous avons créé des projets spécifiques pour les cosmétiques, l'alimentation animale et les autres produits (respectivement Open Beauty Facts, Open Pet Food Facts et Open Products Facts). Nous sommes donc heureux de pouvoir importer vos produits dans le projet qui leur convient.</p> | ||
| </div> | ||
|
|
||
| <script> | ||
| function onMount(fn) { | ||
| if (document.readyState === "loading") { | ||
| document.addEventListener("DOMContentLoaded", fn); | ||
| } else { | ||
| fn(); | ||
| } | ||
| } | ||
|
|
||
| onMount(() => { | ||
| function sendHeight() { | ||
| const height = document.body.scrollHeight; | ||
| console.debug("Calculated height: " + height); | ||
| if (typeof parent !== 'undefined' && parent !== window) { | ||
| parent.postMessage({ frameHeight: height }, '*'); | ||
| } | ||
| } | ||
| // Send the height on initial load | ||
| sendHeight(); | ||
| // Send the height whenever the window is resized | ||
| window.addEventListener("resize", sendHeight); | ||
| }); | ||
| </script> | ||
|
Comment on lines
-244
to
-266
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this for Explorer :)