-
-
Notifications
You must be signed in to change notification settings - Fork 398
feat: Integration of Nutri-Patrol #6315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@Valimp info • To-do comment doesn't follow the Flutter style • packages/smooth_app/lib/pages/product/report_product/report_product_page.dart:48:13 • flutter_style_todos |
|
@Valimp merge conflict to fix following the reindentation of the translation file |
|
@Valimp do you need any help? |
|
@github-throwaway Indeed I'm a bit stuck on a git rebase on another PR on the dart SDK, which delayed me on this one |
|
Could you link that PR? :) |
|
small merge conflict on the translation files |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the initial integration of Nutri-Patrol, adding UI elements and localization for reporting products. The code is well-structured, but there are several areas where implementation is incomplete, marked by TODO comments. Addressing these will be crucial for the feature to be fully functional.
Summary of Findings
- Missing Implementation: The code introduces new UI elements and localization strings for reporting products, but the actual submission of the report to Nutri-Patrol is not implemented. The
TODO(g123k): Envoyer la requête à Nutripatrolneeds to be addressed for the feature to be complete. - TODO comments: There are several TODO comments in the code, such as
TODO(g123k): implement viewLicencesandTODO(g123k): Rajouter photo signaler (header). These indicate incomplete functionality that should be addressed. - Incomplete Product Header Implementation: The
_ReportProductHeaderProductwidget inreport_product_header.dartis currently an empty widget with aTODOcomment. This part of the UI needs to be implemented to provide a complete reporting experience when a product image is not available.
Merge Readiness
The pull request is not ready for merging due to the incomplete implementation of core functionalities, particularly the submission of reports to Nutri-Patrol and the missing product header implementation. The TODO comments indicate areas that need further work. It is recommended that these issues be addressed before merging. I am unable to approve this pull request, and others should review and approve this code before merging.
|
Teolemon routed me over here, since I was not aware that most of the photo reporting UI was already built out but I had already built a fully functioning version of this UI (including submitting the report). I was thinking we can just copy my code for uploading the report over here, plus maybe any missing components? |
|
@andylin2004 that sounds like a great plan, sorry for the delay. |
What
Screenshot
Fixes bug(s)
Part of