Skip to content

Conversation

@g123k
Copy link
Collaborator

@g123k g123k commented Jan 30, 2025

@teolemon teolemon changed the title WIP Nutripatrol (Draft) Integration of Nutri-Patrol Jan 30, 2025
@teolemon teolemon changed the title (Draft) Integration of Nutri-Patrol feat: (Draft) Integration of Nutri-Patrol Feb 5, 2025
@teolemon
Copy link
Member

teolemon commented Feb 5, 2025

@Valimp info • To-do comment doesn't follow the Flutter style • packages/smooth_app/lib/pages/product/report_product/report_product_page.dart:48:13 • flutter_style_todos

@teolemon
Copy link
Member

@Valimp merge conflict to fix following the reindentation of the translation file

@teolemon
Copy link
Member

@Valimp @g123k small conflicts on translation files

@github-throwaway
Copy link
Collaborator

github-throwaway commented Mar 17, 2025

@github-throwaway
Copy link
Collaborator

@Valimp do you need any help?

@Valimp
Copy link
Collaborator

Valimp commented Mar 31, 2025

@github-throwaway Indeed I'm a bit stuck on a git rebase on another PR on the dart SDK, which delayed me on this one

@github-throwaway
Copy link
Collaborator

github-throwaway commented Mar 31, 2025

Could you link that PR? :)

@teolemon
Copy link
Member

small merge conflict on the translation files

@teolemon teolemon changed the title feat: (Draft) Integration of Nutri-Patrol feat: Integration of Nutri-Patrol Apr 19, 2025
@teolemon
Copy link
Member

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the initial integration of Nutri-Patrol, adding UI elements and localization for reporting products. The code is well-structured, but there are several areas where implementation is incomplete, marked by TODO comments. Addressing these will be crucial for the feature to be fully functional.

Summary of Findings

  • Missing Implementation: The code introduces new UI elements and localization strings for reporting products, but the actual submission of the report to Nutri-Patrol is not implemented. The TODO(g123k): Envoyer la requête à Nutripatrol needs to be addressed for the feature to be complete.
  • TODO comments: There are several TODO comments in the code, such as TODO(g123k): implement viewLicences and TODO(g123k): Rajouter photo signaler (header). These indicate incomplete functionality that should be addressed.
  • Incomplete Product Header Implementation: The _ReportProductHeaderProduct widget in report_product_header.dart is currently an empty widget with a TODO comment. This part of the UI needs to be implemented to provide a complete reporting experience when a product image is not available.

Merge Readiness

The pull request is not ready for merging due to the incomplete implementation of core functionalities, particularly the submission of reports to Nutri-Patrol and the missing product header implementation. The TODO comments indicate areas that need further work. It is recommended that these issues be addressed before merging. I am unable to approve this pull request, and others should review and approve this code before merging.

@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🏗️ In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 27, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Ready in 🛡️ Nutri-Patrol Apr 27, 2025
@andylin2004
Copy link
Contributor

Teolemon routed me over here, since I was not aware that most of the photo reporting UI was already built out but I had already built a fully functioning version of this UI (including submitting the report). I was thinking we can just copy my code for uploading the report over here, plus maybe any missing components?

@openfoodfacts openfoodfacts deleted a comment from gemini-code-assist bot Jul 14, 2025
@openfoodfacts openfoodfacts deleted a comment from gemini-code-assist bot Jul 14, 2025
@openfoodfacts openfoodfacts deleted a comment from gemini-code-assist bot Jul 14, 2025
@openfoodfacts openfoodfacts deleted a comment from gemini-code-assist bot Jul 14, 2025
@teolemon
Copy link
Member

@andylin2004 that sounds like a great plan, sorry for the delay.
There are small merge conflicts, but adding the actual logic in complement to @g123k 's UI is indeed the way to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

Report a Problem page has no option to actually report the problem

5 participants