Skip to content

Conversation

@may-tas
Copy link
Contributor

@may-tas may-tas commented Mar 7, 2025

What :

  • Image Editing Functionality implemented in the nutritions editing page.

Summary :

  • The method I used is showPhotoBanner from the product_picture_banner.dart file. This method provides a complete image editing experience including camera, gallery selection, and other image operations.

ISSUE

Recording :

WhatsApp.Video.2025-03-07.at.15.49.59.mp4

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 5.83%. Comparing base (4d9c7fc) to head (68d614d).
Report is 785 commits behind head on develop.

Files with missing lines Patch % Lines
...p/lib/pages/product/edit_product_image_viewer.dart 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6422      +/-   ##
==========================================
- Coverage     9.54%   5.83%   -3.72%     
==========================================
  Files          325     490     +165     
  Lines        16411   29291   +12880     
==========================================
+ Hits          1567    1710     +143     
- Misses       14844   27581   +12737     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@AshAman999 AshAman999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment!

),
),
PositionedDirectional(
bottom: 60.0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @may-tas
I believe the parent component has 20% vertical height, so using the fixed bottom might not be a great way to center the icon, in case of diff mobile height devices,
I might be wrong, but if possible, can you try the same UI in diff mobile devices ? Preferably on any emulator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just followed the code logic other icons were using, I know this could lead to overflow, If you want I can change the approach, but then we would have to change others too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it in android emulator and my physical device it didnt overflow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if should change the approach here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teolemon teolemon requested a review from g123k March 13, 2025 12:43
@g123k
Copy link
Collaborator

g123k commented Mar 13, 2025

OMG Please not that.
The UI was full of buttons of few weeks ago, please don't bring back that kind of UI.

Please, let me do this screen instead of trying any kind of weird fix on it.

@may-tas
Copy link
Contributor Author

may-tas commented Mar 14, 2025

@g123k, as per issue #6422, @teolemon requested adding an "Edit" button between the two existing buttons.

If there's a better way to address this issue, please let me know, and I'll make the necessary changes.

@teolemon teolemon moved this from 💬 To discuss and validate to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Add a shortcut to edit the photo in the nutrition editing

4 participants