Skip to content

feat: Add photo editing icon shortcut to product image viewer of nutrition facts page. #6422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: Add photo editing icon shortcut to product image viewer of nutrition facts page. #6422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions packages/smooth_app/lib/pages/product/edit_product_image_viewer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import 'package:smooth_app/generic_lib/duration_constants.dart';
import 'package:smooth_app/helpers/image_field_extension.dart';
import 'package:smooth_app/helpers/product_cards_helper.dart';
import 'package:smooth_app/helpers/ui_helpers.dart';
import 'package:smooth_app/pages/product/common/product_picture_banner.dart';
import 'package:smooth_app/pages/product/helpers/pinch_to_zoom_indicator.dart';
import 'package:smooth_app/query/product_query.dart';
import 'package:smooth_app/resources/app_icons.dart' as icons;
Expand Down Expand Up @@ -116,6 +117,38 @@ class _EditProductImageViewerState extends State<EditProductImageViewer>
),
),
),
PositionedDirectional(
bottom: 60.0,
Copy link
Member

@AshAman999 AshAman999 Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @may-tas
I believe the parent component has 20% vertical height, so using the fixed bottom might not be a great way to center the icon, in case of diff mobile height devices,
I might be wrong, but if possible, can you try the same UI in diff mobile devices ? Preferably on any emulator.

Copy link
Contributor Author

@may-tas may-tas Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just followed the code logic other icons were using, I know this could lead to overflow, If you want I can change the approach, but then we would have to change others too.

Copy link
Contributor Author

@may-tas may-tas Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it in android emulator and my physical device it didnt overflow.

Copy link
Contributor Author

@may-tas may-tas Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if should change the approach here.

Copy link
Contributor Author

@may-tas may-tas Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshAman999

end: 3.5,
child: Offstage(
offstage: _animation.value != 1.0,
child: Material(
type: MaterialType.transparency,
child: InkWell(
customBorder: const CircleBorder(),
onTap: () async {
final Product product = context.read<Product>();
await showPhotoBanner(
context: context,
product: product,
imageField: widget.imageField,
language:
widget.language ?? ProductQuery.getLanguage(),
);
},
child: Tooltip(
message: AppLocalizations.of(context)
.edit_photo_button_label,
child: const SmoothIndicatorIcon(
icon: icons.Edit(
size: 14.0,
),
),
),
),
),
),
),
PositionedDirectional(
bottom: 1.0,
end: 3.5,
Expand Down