Skip to content

Conversation

@g123k
Copy link
Collaborator

@g123k g123k commented Nov 11, 2025

Better than words, a video:
Search.webm

Note: It's OK for the release, but I will probably change the layout of the history tonight.
iPhone 14 Pro Max Copy

@github-actions github-actions bot added 🥫 Product page 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🌐 l10n 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels Nov 11, 2025
@teolemon teolemon linked an issue Nov 11, 2025 that may be closed by this pull request
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great value adding feature 👍

@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 11, 2025
@teolemon
Copy link
Member

❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/pages/user_preferences_page_test.dart: UserPreferencesPage looks as expected Light (failed)
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: Tappable objects should be at least Size(44.0, 44.0)
Actual: <Instance of 'WidgetTester'>
Which: SemanticsNode#18(Rect.fromLTRB(29.0, 180.0, 733.0, 204.0), tags:
[RenderViewport.excludeFromScrolling, RenderViewport.twoPane], actions: [focus, tap], flags:
[isTextField, hasEnabledState, isEnabled], label: "Search for a setting (e.g. Nutri-Score)",
textDirection: ltr, currentValueLength: 0, inputType: text): expected tap target size of at least
Size(44.0, 44.0), but found Size(704.0, 24.0)
See also:
https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/adaptivity-and-layout/

When the exception was thrown, this was the stack:
#0 fail (package:matcher/src/expect/expect.dart:149:31)
#1 _expect. (package:matcher/src/expect/expect.dart:125:9)


(elided 6 frames from dart:async and package:stack_trace)

The test description was:
Light
════════════════════════════════════════════════════════════════════════════════════════════════════
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test (but after the test had completed):
Expected: Tappable objects should be at least Size(48.0, 48.0)
Actual: <Instance of 'WidgetTester'>
Which: SemanticsNode#18(Rect.fromLTRB(29.0, 180.0, 733.0, 204.0), tags:
[RenderViewport.excludeFromScrolling, RenderViewport.twoPane], actions: [focus, tap], flags:
[isTextField, hasEnabledState, isEnabled], label: "Search for a setting (e.g. Nutri-Score)",
textDirection: ltr, currentValueLength: 0, inputType: text): expected tap target size of at least
Size(48.0, 48.0), but found Size(704.0, 24.0)
See also: https://support.google.com/accessibility/android/answer/7101858?hl=en

When the exception was thrown, this was the stack:
#0 fail (package:matcher/src/expect/expect.dart:149:31)
#1 _expect. (package:matcher/src/expect/expect.dart:125:9)


(elided 6 frames from dart:async and package:stack_trace)
════════════════════════════════════════════════════════════════════════════════════════════════════
Test failed. See exception logs above.
The test description was: Light

Test failed. See exception logs above.
The test description was: Light

❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/pages/user_preferences_page_test.dart: UserPreferencesPage looks as expected Dark (failed)
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: Tappable objects should be at least Size(44.0, 44.0)
Actual: <Instance of 'WidgetTester'>
Which: SemanticsNode#18(Rect.fromLTRB(29.0, 180.0, 733.0, 204.0), tags:
[RenderViewport.excludeFromScrolling, RenderViewport.twoPane], actions: [focus, tap], flags:
[isTextField, hasEnabledState, isEnabled], label: "Search for a setting (e.g. Nutri-Score)",
textDirection: ltr, currentValueLength: 0, inputType: text): expected tap target size of at least
Size(44.0, 44.0), but found Size(704.0, 24.0)
See also:
https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/adaptivity-and-layout/

When the exception was thrown, this was the stack:
#0 fail (package:matcher/src/expect/expect.dart:149:31)
#1 _expect. (package:matcher/src/expect/expect.dart:125:9)


(elided 6 frames from dart:async and package:stack_trace)

The test description was:
Dark
════════════════════════════════════════════════════════════════════════════════════════════════════
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test (but after the test had completed):
Expected: Tappable objects should be at least Size(48.0, 48.0)
Actual: <Instance of 'WidgetTester'>
Which: SemanticsNode#18(Rect.fromLTRB(29.0, 180.0, 733.0, 204.0), tags:
[RenderViewport.excludeFromScrolling, RenderViewport.twoPane], actions: [focus, tap], flags:
[isTextField, hasEnabledState, isEnabled], label: "Search for a setting (e.g. Nutri-Score)",
textDirection: ltr, currentValueLength: 0, inputType: text): expected tap target size of at least
Size(48.0, 48.0), but found Size(704.0, 24.0)
See also: https://support.google.com/accessibility/android/answer/7101858?hl=en

When the exception was thrown, this was the stack:
#0 fail (package:matcher/src/expect/expect.dart:149:31)
#1 _expect. (package:matcher/src/expect/expect.dart:125:9)


(elided 6 frames from dart:async and package:stack_trace)
════════════════════════════════════════════════════════════════════════════════════════════════════
Test failed. See exception logs above.
The test description was: Dark

Test failed. See exception logs above.
The test description was: Dark

❌ /home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/pages/user_preferences_page_test.dart: UserPreferencesPage looks as expected AMOLED (failed)
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: Tappable objects should be at least Size(44.0, 44.0)
Actual: <Instance of 'WidgetTester'>
Which: SemanticsNode#18(Rect.fromLTRB(29.0, 180.0, 733.0, 204.0), tags:
[RenderViewport.excludeFromScrolling, RenderViewport.twoPane], actions: [focus, tap], flags:
[isTextField, hasEnabledState, isEnabled], label: "Search for a setting (e.g. Nutri-Score)",
textDirection: ltr, currentValueLength: 0, inputType: text): expected tap target size of at least
Size(44.0, 44.0), but found Size(704.0, 24.0)
See also:
https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/adaptivity-and-layout/

When the exception was thrown, this was the stack:
#0 fail (package:matcher/src/expect/expect.dart:149:31)
#1 _expect. (package:matcher/src/expect/expect.dart:125:9)


(elided 6 frames from dart:async and package:stack_trace)

The test description was:
AMOLED
════════════════════════════════════════════════════════════════════════════════════════════════════
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test (but after the test had completed):
Expected: Tappable objects should be at least Size(48.0, 48.0)
Actual: <Instance of 'WidgetTester'>
Which: SemanticsNode#18(Rect.fromLTRB(29.0, 180.0, 733.0, 204.0), tags:
[RenderViewport.excludeFromScrolling, RenderViewport.twoPane], actions: [focus, tap], flags:
[isTextField, hasEnabledState, isEnabled], label: "Search for a setting (e.g. Nutri-Score)",
textDirection: ltr, currentValueLength: 0, inputType: text): expected tap target size of at least
Size(48.0, 48.0), but found Size(704.0, 24.0)
See also: https://support.google.com/accessibility/android/answer/7101858?hl=en

When the exception was thrown, this was the stack:
#0 fail (package:matcher/src/expect/expect.dart:149:31)
#1 _expect. (package:matcher/src/expect/expect.dart:125:9)


(elided 6 frames from dart:async and package:stack_trace)
════════════════════════════════════════════════════════════════════════════════════════════════════
Test failed. See exception logs above.
The test description was: AMOLED

Test failed. See exception logs above.
The test description was: AMOLED

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 6.63717% with 633 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.76%. Comparing base (4d9c7fc) to head (9920889).
⚠️ Report is 1219 commits behind head on develop.

Files with missing lines Patch % Lines
...lib/pages/search/product_type_search_selector.dart 3.12% 31 Missing ⚠️
...kages/smooth_app/lib/pages/search/search_hint.dart 0.00% 14 Missing ⚠️
...es/smooth_app/lib/pages/search/search_app_bar.dart 0.00% 11 Missing ⚠️
.../carousel/main_card/top_card/scan_search_card.dart 0.00% 10 Missing ⚠️
...app/lib/pages/product/product_type_extensions.dart 0.00% 9 Missing ⚠️
...ages/smooth_app/lib/pages/search/search_field.dart 78.37% 8 Missing ⚠️
...ooth_app/lib/pages/search/search_history_view.dart 0.00% 8 Missing ⚠️
...kages/smooth_app/lib/pages/search/search_page.dart 0.00% 8 Missing ⚠️
...kages/smooth_app/lib/resources/app_animations.dart 0.00% 8 Missing ⚠️
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% 4 Missing ⚠️
... and 135 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7205       +/-   ##
============================================
- Coverage     9.54%    4.76%    -4.79%     
============================================
  Files          325      709      +384     
  Lines        16411   276378   +259967     
============================================
+ Hits          1567    13168    +11601     
- Misses       14844   263210   +248366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teolemon teolemon merged commit a3c1822 into openfoodfacts:develop Nov 11, 2025
8 checks passed
@g123k g123k deleted the oxf_search_bar branch November 11, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

goldens 🌐 l10n 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 🔎 Search 🧪 Tests

Development

Successfully merging this pull request may close these issues.

Make universal search accessible to everyone

3 participants