Skip to content

Conversation

@brada4
Copy link
Contributor

@brada4 brada4 commented Nov 9, 2025

Use upstream key generation method using openssh's keygen

  • adjust dependencies dropbearconveret -> openssh-keygen
  • use precise path to a security related tool
  • avoid sed-hack-ing comment into keyfile ipo standard parameter
  • leaves never accessed dropbear-based keygen imitation in place

Source: upstream ./arch/turris-sw-probe/turris-sw-probe-ATLAS.sh L67

📦 Package Details

Maintainer: not @BKPepe

Description:
Package just breaks when user tries to activate probe, works after patch.

🧪 Run Testing Details

Did not bother

✅ Formalities

  • [ x] I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • [ x] It can be applied using git am
  • [ x] It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • [x ] It is structured in a way involving correct bits from the upstream

Fixes: #27763
Fixes: #25588

@brada4 brada4 closed this Nov 10, 2025
@brada4 brada4 reopened this Nov 10, 2025
@brada4
Copy link
Contributor Author

brada4 commented Nov 10, 2025

re-trigger CI, mandatory dependency sudo crashing?

Use upstream key generation method using openssh's keygen
- adjust dependencies dropbearconveret -> openssh-keygen
- use precise path to a security related tool
- avoid sed-hack-ing comment into keyfile ipo standard parameter
- leaves never accessed dropbear-based keygen imitation in place

Source: upstream ./arch/turris-sw-probe/turris-sw-probe-ATLAS.sh L67
Signed-off-by: Andris PE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

atlas-sw-probe: wrong flags used in ssh-keygen, no exception handling for failed ssh-keygen invocations. atlas-sw-probe is heavily broken

1 participant