fix: inverse argument order for assertThat rule

Author: jfredon

src/Rules/Assertions/AbstractAssertionToExpectation.php

@@ -62,6 +62,15 @@ protected function buildExpect(MethodCall $methodCall): Expr
         );
     }
 
+    private function getActualPosition(): int
+    {
+        if ($this->oldName === 'assertThat') {
+            return 0;
+        }
+
+        return $this->argumentCount >= 3 ? 1 : 0;
+    }
+
     /**
      * Extract the expected arguments.
      *
@@ -70,7 +79,7 @@ protected function buildExpect(MethodCall $methodCall): Expr
      */
     private function expected(array $args): array
     {
-        $actualPosition = $this->argumentCount >= 3 ? 1 : 0;
+        $actualPosition = $this->getActualPosition();
 
         unset($args[$actualPosition]);
 
@@ -84,7 +93,7 @@ private function expected(array $args): array
      */
     private function actual(array $args): Arg|VariadicPlaceholder
     {
-        $actualPosition = $this->argumentCount >= 3 ? 1 : 0;
+        $actualPosition = $this->getActualPosition();
 
         $actualArgument = $args[$actualPosition];
 

tests/Converters/CodeConverterTest.php

@@ -1213,7 +1213,7 @@ public function test_assert_matches_regular_expression()
         class MyTest {
             public function test_assert_that()
             {
-                $this->assertThat(new IsTrue(), true);
+                $this->assertThat(true, new IsTrue());
             }
         }
     ';