Skip to content

add more libraries to Libs.private for static linking #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add more libraries to Libs.private for static linking #217

wants to merge 1 commit into from

Conversation

@msakai
Copy link
Member

@msakai msakai commented Feb 7, 2019

We need to list all privately used libraries in Libs.private for static linking to work.

Note that -lstdc++ and -lm seem to work also on macOS.

@msakai
add more libraries to Libs.private for static linking
dd8d2b3 
We need to list all privately used libraries in Libs.private for
static linking to work. Note that -lstdc++ and -lm seem to work
also on macOS.
@msakai msakai requested a review from okdshin February 7, 2019 05:43
@okdshin
Copy link
Contributor

okdshin commented Feb 7, 2019

Users who doesn't use mkldnn but tensorrt needn't link libmkldnn.
So we need to change @MKLDNN_LIBRARY@ part depending on ENABLE_MKLDNN.

@msakai
Copy link
Member Author

msakai commented Feb 18, 2019

Yes. It is desirable when ENABLE_MKLDNN flag is added to master.
If it takes more time for tensorrt branch to be mature enough for merging, how about cherry-picking ENABLE_MKLDNN feature from tensorrt branch into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@okdshin okdshin Awaiting requested review from okdshin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msakai @okdshin