Add tests for each user group #5343
Open
+327
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinreiss
requested changes
Nov 7, 2025
Member
kevinreiss
left a comment
kevinreiss
left a comment
There was a problem hiding this comment.
Thanks @rladdusaw. A couple of questions we can discuss on Monday.
| end | ||
|
|
||
| def eligible? | ||
| return false unless patron_group_eligible? || patron.guest? |
Member
There was a problem hiding this comment.
Do we need to add this check for Aeon items? All users should be able to see this option. I think https://github.com/pulibrary/orangelight/blob/main/docs/requests/patron_groups.md is incorrect. Aeon should probably be in it's own category as any user (including the "guest" user in the blacklight sense should be allowed to see the links for Reading Room Requests.
Member
There was a problem hiding this comment.
The Aeon items seem to be working fine in QA.
rladdusaw
force-pushed
the
5307-audit-alma-provider
branch
from
d252ec3 to
578ca3c
Compare
kevinreiss
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5307