Removes aliasing in Feols

[Dpananos]

Addresses #853

All tests passing with pixi run -e dev tests-regular running larger tests now.

Will remove from draft state once I run pixi run -e dev tests

[Dpananos]

Looks like there are some failing tests, but they fail on master too. Failing tests are in tests/test_hac_vs_fixest.py Can someone let me know if that is expected?

[s3alfisc]

Yes, this is expected and should be all good - these test fail due to python multi threading leading to floating point errors that accumulate. Will ping you in the thread on discord. You can test the Hac Errors enforcing single threads by running pixi r -dev tests-hac.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 88 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pyfixest/estimation/feols_.py	0.00%	88 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (24a5b25) and HEAD (0065d7f). Click for more details.

HEAD has 3 uploads less than BASE

Flag	BASE (24a5b25)	HEAD (0065d7f)
core-tests	2	0
tests-extended	1	0

Flag	Coverage Δ
core-tests	?
tests-extended	?
tests-vs-r	16.00% <0.00%> (+0.18%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pyfixest/estimation/feols_.py	7.86% <0.00%> (-83.88%)	⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Dpananos]

Ok, ran

OMP_NUM_THREADS=1 OPENBLAS_NUM_THREADS=1 MKL_NUM_THREADS=1 VECLIB_MAXIMUM_THREADS=1 pixi run -e dev pytest tests/test_hac_vs_fixest.py -v

All tests either skipped or successful

Results (986.97s (0:16:26)):
    2517 passed
    1504 skipped

[Dpananos]

@s3alfisc LMK if you can approve or there are additional changes required. Seems like codecov failed b/c of the HAC tests

[s3alfisc]

This looks good to me. Thank you @Dpananos!

I think it would be best to fix the codecov error in a separate PR?

[s3alfisc]

@all-contributors please add @Dpananos for code

[allcontributors]

@s3alfisc

I've put up a pull request to add @Dpananos! 🎉