Skip to content

Conversation

@enrichman
Copy link
Collaborator

@enrichman enrichman commented Sep 3, 2025

This PR cleanup a bit the Makefile, adding envtest to the controller (yet without tests), a couple of GHA for the lint, build and tests, simplify the golangci-lint configuration.

@enrichman enrichman force-pushed the cleanup-test-lint branch 2 times, most recently from 23dfa67 to 19473b2 Compare September 5, 2025 14:43
@enrichman enrichman changed the title [WIP] cleanup wip Cleanup Makefile, tests and CI Sep 5, 2025
@enrichman enrichman marked this pull request as ready for review September 5, 2025 14:46
@enrichman enrichman self-assigned this Sep 5, 2025
@enrichman enrichman requested review from galal-hussein and jp-gouin and removed request for galal-hussein September 8, 2025 10:10
Copy link

@jp-gouin jp-gouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @enrichman

@enrichman enrichman merged commit c0646f1 into rancher:main Sep 8, 2025
3 checks passed
@enrichman enrichman deleted the cleanup-test-lint branch September 8, 2025 15:09
@enrichman enrichman mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants