rptest/services/admin: typify a few functions

list_reconfigurations,
get_partition,
set_partition_replicas,
transfer_leadership_to

Author: bashtanov

tests/rptest/services/admin.py

@@ -15,7 +15,7 @@
 from enum import Enum
 from json.decoder import JSONDecodeError
 from logging import Logger
-from typing import Any, Callable, NamedTuple, Optional, Protocol, cast
+from typing import Any, Callable, List, NamedTuple, Optional, Protocol, cast
 from uuid import UUID
 
 import requests
@@ -1094,7 +1094,7 @@ def trigger_cores_rebalance(self, node):
 
         return self._request("post", path, node=node)
 
-    def list_reconfigurations(self, node=None):
+    def list_reconfigurations(self, node: ClusterNode | None = None):
         """
         List pending reconfigurations
         """
@@ -1135,7 +1135,9 @@ def get_partitions(self, topic=None, partition=None, *, namespace=None, node=Non
 
         return self._request("get", path, node=node).json()
 
-    def get_partition(self, ns: str, topic: str, id: int, node=None):
+    def get_partition(
+        self, ns: str, topic: str, id: int, node: ClusterNode | None = None
+    ) -> dict[str, Any]:
         return self._request("GET", f"partitions/{ns}/{topic}/{id}", node=node).json()
 
     def get_transactions(self, topic, partition, namespace, node=None):
@@ -1193,7 +1195,12 @@ def find_tx_coordinator(self, tid, node=None):
         return self._request("get", path, node=node).json()
 
     def set_partition_replicas(
-        self, topic, partition, replicas, *, namespace="kafka", node=None
+        self,
+        topic: str,
+        partition: int,
+        replicas: List[dict[str, int]],
+        namespace: str = "kafka",
+        node: ClusterNode | None = None,
     ):
         """
         [ {"node_id": 0, "core": 1}, ... ]
@@ -1402,8 +1409,14 @@ def get_partition_leader(self, *, namespace, topic, partition, node=None):
         return partition_info["leader_id"]
 
     def transfer_leadership_to(
-        self, *, namespace, topic, partition, target_id=None, leader_id=None
-    ):
+        self,
+        *,
+        namespace: str,
+        topic: str,
+        partition: int,
+        target_id: int | None = None,
+        leader_id: int | None = None,
+    ) -> bool:
         """
         Looks up current ntp leader and transfer leadership to target node,
         this operations is NOP when current leader is the same as target.