Meson improvements #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximion
force-pushed
the
master
branch
3 times, most recently
from
4e55362 to
833cf9d
Compare
Contributor
Author
|
As expected, GDC didn't like the change (it's version (4.8) is really old on Travis, 8.1 would work though). I excluded GDC from running Meson on the CI, so everything should be good now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think mustache-d was one of the first D projects to have a Meson build definition, and it's showing its age - for example, by only allowing to build a static library, while meanwhile all D compilers can build shared libraries.
This PR contains one patch to modernize the Meson definition (and to add running tests to it), and another patch to test the Meson builds on the CI as well.
For the CI patch I am not sure yet whether it will succeed with GDC, since the GDC version on Travis is a bit old. If it fails, I will change the patch.
Thanks for considering :-)
(I will push at least the non-static-lib change to Debian, because having only a static library causes problems with automatic package rebuilds when a new D compiler version is out)