storefront fails build with latest saleor (3.21) - Docker - [FAILED] Unknown scalar type Hour.

[borisaguilar]

Summary

When building using the api from the 3.21 saleor release, the following error happens:

=> [runner 3/8] RUN adduser --system --uid 1001 nextjs 0.3s
=> [builder 4/5] RUN corepack enable 0.6s
=> ERROR [builder 5/5] RUN pnpm build 12.4s

[builder 5/5] RUN pnpm build:
#0 0.927 ! Corepack is about to download https://registry.npmjs.org/pnpm/-/pnpm-9.6.0.tgz
#0 4.955
#0 4.955 > saleor-storefront@0.1.0 prebuild /app
#0 4.955 > pnpm run generate
#0 4.955
#0 5.761
#0 5.761 > saleor-storefront@0.1.0 generate /app
#0 5.761 > graphql-codegen --config .graphqlrc.ts
#0 5.761
#0 6.783 [STARTED] Parse Configuration
#0 6.784 [SUCCESS] Parse Configuration
#0 6.784 [STARTED] Generate outputs
#0 6.785 [STARTED] Generate to src/gql/
#0 6.785 [STARTED] Generate to src/gql/documentNodes/
#0 6.880 [STARTED] Load GraphQL schemas
#0 6.880 [STARTED] Load GraphQL schemas
#0 12.13 [SUCCESS] Load GraphQL schemas
#0 12.13 [SUCCESS] Load GraphQL schemas
#0 12.13 [STARTED] Load GraphQL documents
#0 12.13 [STARTED] Load GraphQL documents
#0 12.17 [SUCCESS] Load GraphQL documents
#0 12.17 [STARTED] Generate
#0 12.17 [FAILED] Unknown scalar type Hour. Please override it using the "scalars" configuration field!
#0 12.18 [SUCCESS] Load GraphQL documents
#0 12.18 [STARTED] Generate
#0 12.18 [FAILED] Unknown scalar type Hour. Please override it using the "scalars" configuration field!
#0 12.18 [SUCCESS] Generate outputs
#0 12.22  ELIFECYCLE  Command failed with exit code 1.
#0 12.26  ELIFECYCLE  Command failed with exit code 1.

Steps to reproduce

1. Clone the storefront repo
2. Build using the api URL saleor version 3.21 (either docker compose build or pnpm build)
3. Cry because you don't understand the error

A link to a reproduction repository

No response

Output from envinfo

No response

[borisaguilar]

Apparently editing the .graphqlrc.ts file and adding: Hour: "string", fixes the problem... but TBH I don't know if something else might break.

Here's a working .graphqlrc.ts for 3.21:

import { loadEnvConfig } from "@next/env";
import type { CodegenConfig } from "@graphql-codegen/cli";

loadEnvConfig(process.cwd());

let schemaUrl = process.env.NEXT_PUBLIC_SALEOR_API_URL;

if (process.env.GITHUB_ACTION === "generate-schema-from-file") {
	schemaUrl = "schema.graphql";
}

if (!schemaUrl) {
	console.error(
		"Before GraphQL types can be generated, you need to set NEXT_PUBLIC_SALEOR_API_URL environment variable.",
	);
	console.error("Follow development instructions in the README.md file.");
	process.exit(1);
}

const config: CodegenConfig = {
	overwrite: true,
	schema: schemaUrl,
	documents: "src/graphql/**/*.graphql",
	generates: {
		"src/gql/": {
			preset: "client",
			plugins: [],
			config: {
				documentMode: "string",
				useTypeImports: true,
				strictScalars: true,
				scalars: {
					Date: "string",
					DateTime: "string",
					Day: "number",
					Decimal: "number",
					GenericScalar: "unknown",
					JSON: "unknown",
					JSONString: "string",
					Metadata: "Record<string, string>",
					Minute: "number",
					PositiveDecimal: "number",
					UUID: "string",
					Upload: "unknown",
					WeightScalar: "unknown",
					_Any: "unknown",
                                        Hour: "string",
				},
			},
			presetConfig: {
				fragmentMasking: false,
			},
		},
		"src/gql/documentNodes/": {
			preset: "client",
			plugins: [],
			config: {
				documentMode: "documentNode",
				useTypeImports: true,
				strictScalars: true,
				scalars: {
					Date: "string",
					DateTime: "string",
					Day: "number",
					Decimal: "number",
					GenericScalar: "unknown",
					JSON: "unknown",
					JSONString: "string",
					Metadata: "Record<string, string>",
					Minute: "number",
					PositiveDecimal: "number",
					UUID: "string",
					Upload: "unknown",
					WeightScalar: "unknown",
					_Any: "unknown",
                                        Hour: "string",
				},
			},
			presetConfig: {
				fragmentMasking: false,
			},
		},
	},
};

export default config;

[p-febis]

String seems like the wrong way to go about it, I feel like it should be number, this is the second time I've seen this so I will make a PR to address it.