fixup! Apply suggestions from code review

Author: Akretsch

src/test/java/com/siemens/pki/cmpclientcomponent/test/CmpClientTestcaseBase.java

@@ -120,7 +120,7 @@ protected static CmpMessageInterface getPasswordBasedUpstreamconfigurationWithou
 
             @Override
             public VerificationContext getInputVerification() {
-                return null;
+                return new PasswordValidationCredentials(protection.getSharedSecret());
             }
 
             @Override

src/test/java/com/siemens/pki/cmpclientcomponent/test/TestPasswordBasedIrWithoutResponseValidation.java

@@ -21,6 +21,7 @@
 
 import com.siemens.pki.cmpclientcomponent.main.CmpClient.EnrollmentResult;
 import com.siemens.pki.cmpracomponent.configuration.Configuration;
+import com.siemens.pki.cmpracomponent.msgvalidation.CmpValidationException;
 import com.siemens.pki.cmpracomponent.test.framework.ConfigurationFactory;
 import com.siemens.pki.cmpracomponent.test.framework.SharedSecret;
 import com.siemens.pki.cmpracomponent.test.framework.TestUtils;
@@ -34,21 +35,29 @@ public class TestPasswordBasedIrWithoutResponseValidation extends EnrollmentTest
     @Before
     public void setUp() throws Exception {
         final Configuration config =
-                ConfigurationFactory.buildPasswordbasedDownstreamConfigurationWithoutResponseValidation();
+                ConfigurationFactory.buildPasswordbasedDownstreamConfigurationWithoutResponseProtection();
         launchCmpCaAndRa(config);
     }
 
-    @Test
-    public void testIrWithoutResponseValidation() throws Exception {
-        final EnrollmentResult ret = getPasswordBasedCmpClientWithoutResponseValidation(
-                        "theCertProfileForOnlineEnrollmentWithoutResponseValidation",
-                        getClientContext(
-                                PKIBody.TYPE_CERT_REQ,
-                                ConfigurationFactory.getKeyGenerator().generateKeyPair(),
-                                null),
-                        new SharedSecret("PASSWORDBASEDMAC", TestUtils.PASSWORD),
-                        null)
-                .invokeEnrollment();
-        assertNotNull(ret);
+    /**
+     *
+     * @throws Throwable if unprotected response is received
+     */
+    @Test(expected = CmpValidationException.class)
+    public void testIrWithoutResponseValidation() throws Throwable {
+        try {
+            final EnrollmentResult ret = getPasswordBasedCmpClientWithoutResponseValidation(
+                            "theCertProfileForOnlineEnrollmentWithoutResponseValidation",
+                            getClientContext(
+                                    PKIBody.TYPE_CERT_REQ,
+                                    ConfigurationFactory.getKeyGenerator().generateKeyPair(),
+                                    null),
+                            new SharedSecret("PASSWORDBASEDMAC", TestUtils.PASSWORD),
+                            null)
+                    .invokeEnrollment();
+            assertNotNull(ret);
+        } catch (RuntimeException ex) {
+            throw ex.getCause();
+        }
     }
 }

src/test/java/com/siemens/pki/cmpracomponent/test/framework/ConfigurationFactory.java

@@ -101,7 +101,7 @@ public static Configuration buildPasswordbasedDownstreamConfiguration() throws E
                 enrollmentTrust);
     }
 
-    public static Configuration buildPasswordbasedDownstreamConfigurationWithoutResponseValidation() throws Exception {
+    public static Configuration buildPasswordbasedDownstreamConfigurationWithoutResponseProtection() throws Exception {
 
         final VerificationContext downstreamTrust = new PasswordValidationCredentials(TestUtils.PASSWORD);