-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Chocolatey Package Identification in Discovery step #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sumanthkb44
wants to merge
33
commits into
development
Choose a base branch
from
feature/ChocoPackages_Discovery
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for Choco package management in the application. Key changes include: - Added a `Choco` property to `CommonAppSettings.cs` for configuration. - Updated project type mappings in `CommonHelper.cs` to recognize "CHOCO". - Enhanced `BomCreator.cs` to handle the "CHOCO" project type. - Modified `DisplayInformation.cs` to include "CHOCO" in include/exclude mappings. - Updated `NugetProcessor.cs` to identify internal components for Choco packages. - Introduced `ChocoProcessor.cs` to parse Choco configuration files. These changes integrate Choco management seamlessly with existing functionalities.
Updated `AddSiemensDirectProperty` method to be instance-based in `NugetParserTests.cs` for better encapsulation. Introduced a new method in `ChocoProcessor.cs` to add SiemensDirect properties to BOM components, including handling for null properties and duplicate entries. Changed the method in `NugetProcessor.cs` from static to virtual to allow for overriding in derived classes.
Modified the `CommonIdentiferHelper` class to append the "_Bom.cdx.json" suffix to the BOM file name. Updated the corresponding unit test to assert the new file name format, ensuring consistency in the expected output.
feat: Choco packages testcase updated for Choco.
Modified the `ChocoProcessor` constructor to include an additional `null` parameter in the call to the base class `NugetProcessor`. The `ISpdxBomParser spdxBomParser` parameter remains unchanged, reflecting an update in the expected parameters for the base class.
…ry_choco-dev-to-release
…-release feat: Update the CA Tool Artifactory Uploader to Move internal Choco packages from dev to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes