-
Notifications
You must be signed in to change notification settings - Fork 9
Description
The filtered-search currently uses the siTypeahead. The problem is, that in most cases the filtered-search it is actually abusing the typeahead. In the past this was leading to weird constructs, like adding multi-select to the typeahead.
As a background: A typeahead only provides suggestions, to complete the text in an input. Nothing more!
But the filtered-search needs as well:
- in most cases verification, that a certain option was selected
- options that are more than just a string
- actions that can be executed instead of selecting an option
- multi selection
- highlighting the selected option without having the filter value matching it
We actually have a component that does exactly this: the si-select!
But there is actually also a valid use-case for the typeahead in the filtered-search: if a criteria does not enforce the selection of an option, we indeed want to have a normal typeahead.
What should we do now?
Obviously, change something. The problem is, we cannot use the si-select in the filtered-search, as we want to have the search input inline and not as in the si-select in the overlay. In addition, we also need to use the search form the typeahead. So we need to introduce a new internal component, that behaves as described. Since it is basically a select, we should re-use every applicable part of the si-select but enhance it with the typeahead logic.