Skip to content

Conversation

@Killusions
Copy link
Member

@Killusions Killusions commented Aug 19, 2025

This adds the chat-container (fully declarative with auto-scroll), potential follow-ups are an ai-chat-container wrapper (model based with a nice signal-based API for streaming / loading state), dogfooded) in #998 (tool message is here #967 )

The chat input is in #948 (merged), the base components (merged) in #877, the file upload directive (merged) in #932

Rough Architecture (ignore the ai chat container for now and the tool message, not a part of this)
ai-chat-container


@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch 4 times, most recently from 0d15650 to 924a70b Compare August 20, 2025 16:25
@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch 2 times, most recently from 051e889 to 94c9e65 Compare September 1, 2025 12:46
@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch 24 times, most recently from d16d18e to 287eb7d Compare September 22, 2025 14:34
@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch 4 times, most recently from 9f9540a to 19d404a Compare November 7, 2025 18:35
@Killusions
Copy link
Member Author

Did some improvements and changed it to use the same entrypoint after discussing with @kfenner , will split into two PRs

@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch 2 times, most recently from 3b23d72 to 6b82cff Compare November 10, 2025 10:45
@Killusions Killusions mentioned this pull request Nov 10, 2025
1 task
@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch from 6b82cff to 4cd6a1e Compare November 10, 2025 10:49
@Killusions
Copy link
Member Author

@kfenner @spike-rabbit Refactored out the model-API wrapper to #998 , ready to review

@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch from 4cd6a1e to bbc251a Compare November 10, 2025 10:57
@Killusions Killusions changed the title feat(ai-chat): add chat container feat(chat-messages): add chat container Nov 10, 2025
@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch from bbc251a to 4160a81 Compare November 10, 2025 11:01
@Killusions Killusions changed the title feat(chat-messages): add chat container feat: add chat container Nov 10, 2025
@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch 2 times, most recently from 1df7aa4 to 85d877c Compare November 10, 2025 12:54
@Killusions Killusions force-pushed the feat/add-chat-components-in-chat-messages branch from 85d877c to 771a752 Compare November 11, 2025 16:17
@github-actions
Copy link

Code Coverage

Copy link
Member

@kfenner kfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Killusions Love it 💜

LGTM 👍

@kfenner kfenner merged commit 8d2cc1d into main Nov 12, 2025
11 checks passed
@kfenner kfenner deleted the feat/add-chat-components-in-chat-messages branch November 12, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants