docs(buttons): update icon button docs #964
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panch1739
added
documentation
|
|
|
Documentation. Coverage Reports: |
ljanner
reviewed
Nov 5, 2025
Comment on lines
79
to
81
| | Padding left/right | `$spacing-l` | | | ||
| | Padding top/bottom | `$spacing-s` | | | ||
| | Spacing(margin) | `$spacing-l` | Spacing between buttons and other components/containers | |
Member
There was a problem hiding this comment.
Suggested change
| | Spacing(margin) | `$spacing-l` | Spacing between buttons and other components/containers | | |
| | Padding left/right | `$spacing-6` | | | |
| | Padding top/bottom | `$spacing-2` | | | |
| | Spacing(margin) | `$spacing-6` | Spacing between buttons and other components/containers | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the button docs to start introducing the square variant.
@kfenner I'm unsure whether we should start documenting the variant slowly...perhaps just by mentioning its existence first. Later, we can add more context, such as when to use the square versus the circle variant.
To do this properly, I’ll need to go through each component, compare it with IX, and uncover the underlying pattern.
I’ve updated the Figma file, so the correct styling is now available. However, I couldn’t find the PR where this variant was introduced in the code...so im unsure if creating a separate issue to align the styling.