feat: migrate to ix v4 release candidate #157
Conversation
Summary of ChangesHello @alexkaduk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant migration of the application to the Siemens iX v4 Release Candidate. The primary goal is to modernize the UI framework usage, ensuring compatibility with the latest iX design system. This involves updating various iX-related dependencies, adapting component properties to new v4 standards, and implementing a more robust and declarative theme management system. The changes aim to improve maintainability, leverage new features, and prepare the application for future iX updates. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the application to the iX v4 release candidate. The changes are comprehensive, covering dependency updates, component API migrations (especially for buttons), and a complete overhaul of the theme system to use the new data-attribute-based approach. The integration with AG-Grid and ECharts has also been updated correctly. The code is clean and follows the new v4 patterns well. The two new markdown files, MIGRATION_V4_DOCUMENTATION.md and THEME_SYSTEM_EXPLANATION.md, are excellent additions for project knowledge. My review includes a few suggestions to improve the consistency and accuracy of the migration documentation to avoid confusion for future readers.
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| import { themeSwitcher } from "@siemens/ix"; |
There was a problem hiding this comment.
The core theme switcher is still available. Only the Angular specific has been removed. Or is there another reason we changed this file?
There was a problem hiding this comment.
reverted, thanks
There was a problem hiding this comment.
I think themeSwitcher is still not use correctly, you are applying the the ix-theme attribute directly inside the dom but you can utilize the themeSwitcher
apps/react-starter/src/pages/devices/components/ag-grid-table/quick-actions-cell-renderer.tsx
Show resolved
Hide resolved
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| import { themeSwitcher } from "@siemens/ix"; |
There was a problem hiding this comment.
I think themeSwitcher is still not use correctly, you are applying the the ix-theme attribute directly inside the dom but you can utilize the themeSwitcher
danielleroux
changed the base branch from
main
to
feat/3331-migrate-starter-app
danielleroux
merged commit 67354a1
into
siemens:feat/3331-migrate-starter-app
3 participants
No description provided.