Skip to content

Update echarts dep to v6 #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update echarts dep to v6 #2250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
203caa0
Update echarts dep to v6
hemi-siemens Nov 6, 2025
5c113c5
Merge branch 'main' into update-dep-echarts-v6
hemi-siemens Nov 6, 2025
098b6b0
Merge branch 'main' into update-dep-echarts-v6
danielleroux Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/five-items-applaud.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@siemens/ix-echarts': patch
---

Update echarts dep to v6
6 changes: 3 additions & 3 deletions packages/echarts/package.json
View file
Open in desktop
Copy link
Collaborator

@danielleroux danielleroux Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating echarts to V6 is a breaking change imo. Does it not work to support v5 and v6 here to avoid a major breaking change?

Hows about having v5 or v6 as a peerDependency?

Execute tests for v5 and Execute tests for v6 should verify if both versions are compatible with the latest theming file

Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/siemens/ix",
"directory": "packages/echarts"
},
"version": "3.0.0",
"version": "3.0.1",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating a peer dependency to a new major version (like echarts from v5 to v6) is a breaking change for the consumers of this package. According to semantic versioning (SemVer) conventions, this package should also receive a major version bump to signal this change. Since you mentioned you're new to versioning, the idea is to alert developers using @siemens/ix-echarts that they need to handle potential breaking changes from echarts v6. Therefore, the version should be updated to 4.0.0.

Suggested change
"version": "3.0.1",
"version": "4.0.0",

Copy link
Collaborator

@danielleroux danielleroux Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not update version inside package.json this will be done via changeset

"description": "Siemens iX theme for echarts",
"main": "dist/index.js",
"types": "dist/types/index.d.ts",
Expand All @@ -27,7 +27,7 @@
"devDependencies": {
"@playwright/test": "^1.54.1",
"@rollup/plugin-typescript": "^8.5.0",
"echarts": "^5.5.1",
"echarts": "^6.0.0",
"http-server": "^14.1.1",
"rimraf": "^3.0.2",
"rollup": "^2.79.1",
Expand All @@ -38,6 +38,6 @@
"typescript": "^4.9.5"
},
"peerDependencies": {
"echarts": "^5.3.3"
"echarts": "^6.0.0"
}
}
Binary file added .../echarts.e2e.ts-snapshots/echarts-basic-1-chromium---theme-brand-dark-win32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...echarts.e2e.ts-snapshots/echarts-basic-1-chromium---theme-brand-light-win32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...charts.e2e.ts-snapshots/echarts-basic-1-chromium---theme-classic-dark-win32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...harts.e2e.ts-snapshots/echarts-basic-1-chromium---theme-classic-light-win32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...ts.e2e.ts-snapshots/echarts-more-colors-1-chromium---theme-brand-dark-win32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...s.e2e.ts-snapshots/echarts-more-colors-1-chromium---theme-brand-light-win32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ....e2e.ts-snapshots/echarts-more-colors-1-chromium---theme-classic-dark-win32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...e2e.ts-snapshots/echarts-more-colors-1-chromium---theme-classic-light-win32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.