Allow branch override #167
Conversation
|
I can forward your patch already to the list, putting your email on CC, so that we have transparency in both directions. |
|
BTW, you can also use a different email (gmail etc.) than your author address for submitting and interacting. Important is the extra "From: ..." at the top of the commit message to ensure that attribution goes to your company. You should see what I mean in my forwarding. |
|
@nlabriet Thanks for looking into this (we spoke about it at the OSSEU conference). I'll do the review and comments on the ML. |
|
Yes, thanks for pointing out |
nlabriet
force-pushed
the
nla_branch-override
branch
from
bb294be to
1b9a3c7
Compare
|
I updated the patch with the modification of format-changelog. I am using the branch override with a regular kas file appended on the kas command line. |
|
Need someone to forward to the list again? |
|
Yes please, keeping the mailing list history |
Since eb4d112 when commit and branch are specified, kas checks if the commit is actually contained in the branch. This makes it impossible to have a branch set for a repo but use a commit override to build a merge request on this repo (obviously not yet on the specified branch). This change allows the branch property of repos to be overridden to a specific value, or even to Null. Signed-off-by: Nicolas Labriet <[email protected]>
nlabriet
force-pushed
the
nla_branch-override
branch
from
1b9a3c7 to
18fe04f
Compare
|
I've updated the maximal config version in the schema. Thank you for the review, I will figure out how to interact on the ML for the next issue. |
jan-kiszka
force-pushed
the
next
branch
2 times, most recently
from
2f4115f to
7b26b5e
Compare
3 participants
Hello,
I wanted to send this patch but my company's email client makes it hard to reply to mailing lists.
I hope we can have the discussion here and I will eventually send the patch to the mailing list.
Since eb4d112 when commit and branch are specified, kas checks if the commit is actually contained in the branch.
This makes it impossible to have a branch set for a repo but use a commit override to build a merge request on this repo (obviously not yet on the specified branch).
This change allows the branch property of repos to be overridden to a specific value, or even to Null.
Let me know if the branch override should only accept the Null value. In my use case this is the only value I am interested in.
Regards,
Nicolas