chore: log action filter parameters for job events

Log the parameters used to filter job events by action to improve
traceability and debugging.

Signed-off-by: Michael Adler <[email protected]>

Author: michaeladler

internal/handler/job/events/events.go

@@ -82,6 +82,13 @@ type FilterParams struct {
 
 type Action string
 
+// compile-time check to ensure we implement the zerolog's serialization interface
+var _ zerolog.LogObjectMarshaler = (Action)("")
+
+func (a Action) MarshalZerologObject(e *zerolog.Event) {
+	e.Str("action", string(a))
+}
+
 const (
 	ActionCreate           Action = "CREATE"
 	ActionDelete           Action = "DELETE"
@@ -106,7 +113,8 @@ func AddSubscriber(ctx context.Context, graceInterval time.Duration, filter Filt
 		Dict("filterParams", zerolog.Dict().
 			Strs("clientIDs", filter.ClientIDs).
 			Strs("jobIDs", filter.JobIDs).
-			Strs("workflows", filter.Workflows)).
+			Strs("workflows", filter.Workflows).
+			Interface("actions", filter.Actions)).
 		Strs("tags", tags).
 		Msg("Adding new subscriber for job events")
 
@@ -166,14 +174,14 @@ func RemoveSubscriber(subscriber *Subscriber) {
 	muSubscribers.Lock()
 	defer muSubscribers.Unlock()
 
-	oldSubscribers := subscribers
-	subscribers = make([]*Subscriber, 0, len(subscribers))
-	for _, sub := range oldSubscribers {
+	var newSubscribers []*Subscriber
+	for _, sub := range subscribers {
 		if sub == subscriber {
 			continue
 		}
-		subscribers = append(subscribers, sub)
+		newSubscribers = append(newSubscribers, sub)
 	}
+	subscribers = newSubscribers
 	close(subscriber.ch)
 	log.Info().Str("id", subscriber.id).Msg("Removed subscriber")
 }
@@ -193,9 +201,9 @@ func PublishEvent(ctx context.Context, event JobEvent) {
 	defer muSubscribers.Unlock()
 
 	// the subscribers that are still active and we'll keep
-	count := len(subscribers)
-	newSubscribers := make([]*Subscriber, 0, count)
+	var newSubscribers []*Subscriber
 
+	count := len(subscribers)
 	log.Debug().Int("count", count).Msg("Publishing event to subscribers")
 	for _, sub := range subscribers {
 		ctxLog := log.With().Str("id", sub.id).Logger()