Merge pull request #586 from TylerJGabb/issue-585

stephenafamo · web-flow · commit 96da65fd88a5 · 2025-10-16T22:29:05.000+01:00
fix: #585 Many-to-Many Loader Skipping Related Rows
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Fixed a bug where the generated loaders for many-to-many relationships were skipping related rows. (thanks @TylerJGabb)
+
 ### Added
 
 - Include `shell.nix` for developers using [Nix](https://nixos.org/) to create development environments
diff --git a/gen/templates/loaders/table/110_loaders.go.tpl b/gen/templates/loaders/table/110_loaders.go.tpl
@@ -380,7 +380,7 @@ func (os {{$tAlias.UpSingular}}Slice) Load{{$relAlias}}(ctx context.Context, exe
 
 			{{- $typInfo := $.Types.Index ($.Tables.GetColumn $firstSide.From $local).Type -}}
       {{- with $.Types.GetCompareExpr $.CurrentPackage $.Importer $fromColDef.Type $fromColDef.Nullable $toColDef.Nullable -}}
-				if {{replace "AAA" $fromColGet . | replace "BBB" $toColGet}} {
+				if !({{replace "AAA" $fromColGet . | replace "BBB" $toColGet}}) {
 					continue
 				}
 			{{- end}}

Original file line number	Diff line number	Diff line change
`@@ -380,7 +380,7 @@ func (os {{$tAlias.UpSingular}}Slice) Load{{$relAlias}}(ctx context.Context, exe`
`380`	`380`
`381`	`381`	`{{- $typInfo := $.Types.Index ($.Tables.GetColumn $firstSide.From $local).Type -}}`
`382`	`382`	`{{- with $.Types.GetCompareExpr $.CurrentPackage $.Importer $fromColDef.Type $fromColDef.Nullable $toColDef.Nullable -}}`
`383`		`- if {{replace "AAA" $fromColGet . \| replace "BBB" $toColGet}} {`
	`383`	`+ if !({{replace "AAA" $fromColGet . \| replace "BBB" $toColGet}}) {`
`384`	`384`	`continue`
`385`	`385`	`}`
`386`	`386`	`{{- end}}`