Drop support for Python 3.8, add support for Python 3.13, and update dependencies. #85

v12ganesh · 2025-07-11T10:12:07Z

Proposed changes

Drop support for Python 3.8, add support for Python 3.13, and update dependencies.

Addresses #76, #28, #74

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Functionality update (non-breaking change which updates or changes existing functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

codecov · 2025-07-11T10:14:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.91%. Comparing base (ad37893) to head (2819fac).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   80.72%   80.91%   +0.19%     
==========================================
  Files           3        3              
  Lines         524      524              
  Branches       94       74      -20     
==========================================
+ Hits          423      424       +1     
  Misses         82       82              
+ Partials       19       18       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CHANGELOG.md

CONTRIBUTING.md

pyproject.toml

docs/basic_usage.md

github-actions · 2025-11-03T10:51:21Z

Test Results (macos)

path	passed	failed	subtotal
tests/test_client.py	61	1	62
tests/test_logging.py	3		3
TOTAL	64	1	65

tests/test_client.py

tekhsi_client = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x112b22f90>
capsys = <_pytest.capture.CaptureFixture object at 0x112bc52b0>
instrument = True, sum_count = 5, sum_acq_time = 10.0, sum_data_rate = 50.0
expected_output = 'Average Update Rate:0.50, Data Rate:10.00Mbs'

    @pytest.mark.parametrize(
        ("instrument", "sum_count", "sum_acq_time", "sum_data_rate", "expected_output"),
        [
            (True, 5, 10.0, 50.0, "Average Update Rate:0.50, Data Rate:10.00Mbs"),
        ],
    )
    def test_server_connection(
        tekhsi_client: TekHSIConnect,
        capsys: pytest.CaptureFixture[str],
        instrument: bool,
        sum_count: int,
        sum_acq_time: float,
        sum_data_rate: float,
        expected_output: str,
    ) -> None:
        """Test the server connection using the TekHSI client.
    
        Args:
            tekhsi_client: An instance of the TekHSI client to be tested.
            capsys (CaptureFixture): Pytest fixture to capture system output.
            instrument: Whether the instrument is connected.
            sum_count: The sum count.
            sum_acq_time: The sum acquisition time.
            sum_data_rate: The sum data rate.
            expected_output: The expected output message.
        """
        # Set the required attributes
        tekhsi_client._instrument = instrument
        tekhsi_client._sum_count = sum_count
        tekhsi_client._sum_acq_time = sum_acq_time
        tekhsi_client._sum_data_rate = sum_data_rate
    
        # Set the verbose attribute to True
        tekhsi_client.verbose = True
        # Use the context manager to handle connection
>       with tekhsi_client as connection:
             ^^^^^^^^^^^^^

capsys     = <_pytest.capture.CaptureFixture object at 0x112bc52b0>
captured   = CaptureResult(out='2025-10-27 04:50:12.000888 - enter()\n', err='')
connection = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x112b22f90>
expected_output = 'Average Update Rate:0.50, Data Rate:10.00Mbs'
instrument = True
request    = name: "test_client"

response   = status: CONNECTSTATUS_SUCCESS

sum_acq_time = 10.0
sum_count  = 5
sum_data_rate = 50.0
tekhsi_client = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x112b22f90>

tests/test_client.py:58: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.tox/tests/lib/python3.13/site-packages/tekhsi/tek_hsi_connect.py:211: in __exit__
    self.close()
        exc_tb     = None
        exc_type   = None
        exc_val    = None
        self       = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x112b22f90>
.tox/tests/lib/python3.13/site-packages/tekhsi/tek_hsi_connect.py:443: in close
    self.force_sequence()
        self       = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x112b22f90>
.tox/tests/lib/python3.13/site-packages/tekhsi/tek_hsi_connect.py:500: in force_sequence
    self.connection.RequestNewSequence(request)
        request    = name: "24b4b079-a711-47cc-b919-4d16796e4c0b"

        self       = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x112b22f90>
.tox/tests/lib/python3.13/site-packages/grpc/_channel.py:1166: in __call__
    return _end_unary_response_blocking(state, call, False, None)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        call       = <grpc._cython.cygrpc.SegregatedCall object at 0x112bb3300>
        compression = None
        credentials = None
        metadata   = None
        request    = name: "24b4b079-a711-47cc-b919-4d16796e4c0b"

        self       = <grpc._channel._UnaryUnaryMultiCallable object at 0x112d2f540>
        state      = <grpc._channel._RPCState object at 0x112c09130>
        timeout    = None
        wait_for_ready = None
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

state = <grpc._channel._RPCState object at 0x112c09130>
call = <grpc._cython.cygrpc.SegregatedCall object at 0x112bb3300>
with_call = False, deadline = None

    def _end_unary_response_blocking(
        state: _RPCState,
        call: cygrpc.SegregatedCall,
        with_call: bool,
        deadline: Optional[float],
    ) -> Union[ResponseType, Tuple[ResponseType, grpc.Call]]:
        if state.code is grpc.StatusCode.OK:
            if with_call:
                rendezvous = _MultiThreadedRendezvous(state, call, None, deadline)
                return state.response, rendezvous
            return state.response
>       raise _InactiveRpcError(state)  # pytype: disable=not-instantiable
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
E       	status = StatusCode.FAILED_PRECONDITION
E       	details = ""
E       	debug_error_string = "UNKNOWN:Error received from peer ipv6:%5B::1%5D:50313 {grpc_status:9, grpc_message:""}"
E       >

call       = <grpc._cython.cygrpc.SegregatedCall object at 0x112bb3300>
deadline   = None
state      = <grpc._channel._RPCState object at 0x112c09130>
with_call  = False

.tox/tests/lib/python3.13/site-packages/grpc/_channel.py:996: _InactiveRpcError

Link to workflow run

github-actions · 2025-11-03T10:51:22Z

Test Results (ubuntu)

path	passed	subtotal
tests/test_client.py	62	62
tests/test_logging.py	3	3
TOTAL	65	65

Link to workflow run

github-actions · 2025-11-03T10:51:23Z

Test Results (windows)

path	passed	failed	subtotal
tests\test_client.py	61	1	62
tests\test_logging.py	3		3
TOTAL	64	1	65

tests\test_client.py

tekhsi_client = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x0000023D5287C6E0>
capsys = <_pytest.capture.CaptureFixture object at 0x0000023D5287DBE0>
instrument = True, sum_count = 5, sum_acq_time = 10.0, sum_data_rate = 50.0
expected_output = 'Average Update Rate:0.50, Data Rate:10.00Mbs'

    @pytest.mark.parametrize(
        ("instrument", "sum_count", "sum_acq_time", "sum_data_rate", "expected_output"),
        [
            (True, 5, 10.0, 50.0, "Average Update Rate:0.50, Data Rate:10.00Mbs"),
        ],
    )
    def test_server_connection(
        tekhsi_client: TekHSIConnect,
        capsys: pytest.CaptureFixture[str],
        instrument: bool,
        sum_count: int,
        sum_acq_time: float,
        sum_data_rate: float,
        expected_output: str,
    ) -> None:
        """Test the server connection using the TekHSI client.
    
        Args:
            tekhsi_client: An instance of the TekHSI client to be tested.
            capsys (CaptureFixture): Pytest fixture to capture system output.
            instrument: Whether the instrument is connected.
            sum_count: The sum count.
            sum_acq_time: The sum acquisition time.
            sum_data_rate: The sum data rate.
            expected_output: The expected output message.
        """
        # Set the required attributes
        tekhsi_client._instrument = instrument
        tekhsi_client._sum_count = sum_count
        tekhsi_client._sum_acq_time = sum_acq_time
        tekhsi_client._sum_data_rate = sum_data_rate
    
        # Set the verbose attribute to True
        tekhsi_client.verbose = True
        # Use the context manager to handle connection
>       with tekhsi_client as connection:
             ^^^^^^^^^^^^^

capsys     = <_pytest.capture.CaptureFixture object at 0x0000023D5287DBE0>
captured   = CaptureResult(out='2025-10-27 04:51:32.000751 - ch1:read header\n2025-10-27 04:51:32.000752 - enter()\n', err='')
connection = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x0000023D5287C6E0>
expected_output = 'Average Update Rate:0.50, Data Rate:10.00Mbs'
instrument = True
request    = name: "test_client"

response   = status: CONNECTSTATUS_SUCCESS

sum_acq_time = 10.0
sum_count  = 5
sum_data_rate = 50.0
tekhsi_client = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x0000023D5287C6E0>

tests\test_client.py:58: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.tox\tests\Lib\site-packages\tekhsi\tek_hsi_connect.py:211: in __exit__
    self.close()
        exc_tb     = None
        exc_type   = None
        exc_val    = None
        self       = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x0000023D5287C6E0>
.tox\tests\Lib\site-packages\tekhsi\tek_hsi_connect.py:443: in close
    self.force_sequence()
        self       = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x0000023D5287C6E0>
.tox\tests\Lib\site-packages\tekhsi\tek_hsi_connect.py:500: in force_sequence
    self.connection.RequestNewSequence(request)
        request    = name: "abaabb6d-4019-41ec-bd41-8679caf66087"

        self       = <tekhsi.tek_hsi_connect.TekHSIConnect object at 0x0000023D5287C6E0>
.tox\tests\Lib\site-packages\grpc\_channel.py:1166: in __call__
    return _end_unary_response_blocking(state, call, False, None)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        call       = <grpc._cython.cygrpc.SegregatedCall object at 0x0000023D527D1F40>
        compression = None
        credentials = None
        metadata   = None
        request    = name: "abaabb6d-4019-41ec-bd41-8679caf66087"

        self       = <grpc._channel._UnaryUnaryMultiCallable object at 0x0000023D527CC910>
        state      = <grpc._channel._RPCState object at 0x0000023D528AECF0>
        timeout    = None
        wait_for_ready = None
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

state = <grpc._channel._RPCState object at 0x0000023D528AECF0>
call = <grpc._cython.cygrpc.SegregatedCall object at 0x0000023D527D1F40>
with_call = False, deadline = None

    def _end_unary_response_blocking(
        state: _RPCState,
        call: cygrpc.SegregatedCall,
        with_call: bool,
        deadline: Optional[float],
    ) -> Union[ResponseType, Tuple[ResponseType, grpc.Call]]:
        if state.code is grpc.StatusCode.OK:
            if with_call:
                rendezvous = _MultiThreadedRendezvous(state, call, None, deadline)
                return state.response, rendezvous
            return state.response
>       raise _InactiveRpcError(state)  # pytype: disable=not-instantiable
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
E       	status = StatusCode.FAILED_PRECONDITION
E       	details = ""
E       	debug_error_string = "UNKNOWN:Error received from peer ipv6:%5B::1%5D:50313 {grpc_status:9, grpc_message:""}"
E       >

call       = <grpc._cython.cygrpc.SegregatedCall object at 0x0000023D527D1F40>
deadline   = None
state      = <grpc._channel._RPCState object at 0x0000023D528AECF0>
with_call  = False

.tox\tests\Lib\site-packages\grpc\_channel.py:996: _InactiveRpcError

Link to workflow run

fix: updated pre-commit file, depencies and drop python 3.8

5b18d29

v12ganesh requested review from a team as code owners July 11, 2025 10:12

auto-assign bot assigned v12ganesh Jul 11, 2025

v12ganesh temporarily deployed to package-build July 11, 2025 10:12 — with GitHub Actions Inactive

fix: updated pre-commit yml file

4e8120d

v12ganesh temporarily deployed to package-build July 11, 2025 10:22 — with GitHub Actions Inactive

fix: updated pre-commit file changed the maxkb value

e860626

v12ganesh temporarily deployed to package-build July 11, 2025 11:14 — with GitHub Actions Inactive

fix: updated pre-commit file reverted the maxkb value

87558c0

v12ganesh temporarily deployed to package-build July 11, 2025 11:17 — with GitHub Actions Inactive

nfelt14 requested changes Jul 11, 2025

View reviewed changes

fix: encorporated the PR comments

0437ff4

v12ganesh temporarily deployed to package-build July 14, 2025 05:20 — with GitHub Actions Inactive

fix: resolving doc errors

4570d29

v12ganesh temporarily deployed to package-build July 14, 2025 06:33 — with GitHub Actions Inactive

fix: updated the grpcio version

c988987

v12ganesh temporarily deployed to package-build July 14, 2025 09:58 — with GitHub Actions Inactive

fix: reverted the grpcio version

701a455

v12ganesh temporarily deployed to package-build July 14, 2025 10:25 — with GitHub Actions Inactive

nfelt14 requested changes Jul 14, 2025

View reviewed changes

docs/basic_usage.md Outdated Show resolved Hide resolved

fix: updated the WfmReplyStatus enum values

c0c4dd5

v12ganesh temporarily deployed to package-build July 15, 2025 05:22 — with GitHub Actions Inactive

fix: updated the WfmReplyStatus all enum values

913f135

v12ganesh temporarily deployed to package-build July 15, 2025 06:53 — with GitHub Actions Inactive

fix: update version in requirements.txt file

f179930

v12ganesh temporarily deployed to package-build October 21, 2025 06:46 — with GitHub Actions Inactive

chore: update grpcio and grpcio-tools versions

2819fac

v12ganesh temporarily deployed to package-build October 27, 2025 04:49 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Drop support for Python 3.8, add support for Python 3.13, and update dependencies. #85

Drop support for Python 3.8, add support for Python 3.13, and update dependencies. #85

Uh oh!

v12ganesh commented Jul 11, 2025 •

edited by nfelt14

Loading

Uh oh!

codecov bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 3, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Drop support for Python 3.8, add support for Python 3.13, and update dependencies. #85

Are you sure you want to change the base?

Drop support for Python 3.8, add support for Python 3.13, and update dependencies. #85

Uh oh!

Conversation

v12ganesh commented Jul 11, 2025 • edited by nfelt14 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Types of changes

Checklist

Uh oh!

codecov bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results (macos)

Uh oh!

github-actions bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results (ubuntu)

Uh oh!

github-actions bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results (windows)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

v12ganesh commented Jul 11, 2025 •

edited by nfelt14

Loading

codecov bot commented Jul 11, 2025 •

edited

Loading

github-actions bot commented Nov 3, 2025 •

edited

Loading

github-actions bot commented Nov 3, 2025 •

edited

Loading

github-actions bot commented Nov 3, 2025 •

edited

Loading