Dev/vossmjp/new examples #1519
Merged
Dev/vossmjp/new examples #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vossmjp
reviewed
Nov 5, 2024
Contributor
vossmjp
left a comment
vossmjp
left a comment
There was a problem hiding this comment.
Please remove lodepng files from PR.
Contributor
There was a problem hiding this comment.
Please remove this file from your PR.
Contributor
There was a problem hiding this comment.
Please remove this file from your PR
fixed a comment
added tbb:: (not needed due to CTAD - but it is more consistent with the book style
pass by ref as Mike suggested
pass by ref only works on first param
final answer
const & - final answer for this example
const & - final answer for this example
vossmjp
merged commit 2ba2c23
into
uxlfoundation:dev/vossmjp/new_examples
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
finished algorithms chapter - added/modified files as needed.
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information