Skip to content
Merged
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions rfcs/proposed/numa_support/tbbbind-link-static-hwloc.org
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
# -*- fill-column: 80; -*-

#+title: Link ~tbbbind~ with static HWLOC to improve predictability of NUMA support API

*Note:* This is a sub-RFC of the https://github.com/oneapi-src/oneTBB/pull/1535.
Specifically, its section about "Increased availability of NUMA support".

* Introduction
oneTBB has a soft dependency on several variants of ~tbbbind~, which are loaded
by the library as part of its initialization stage. In turn, each ~tbbbind~ has
a hard dependency on a concrete version of the HWLOC library [1, 2]. The soft
dependency of oneTBB on ~tbbbind~ allows the library to continue its execution
even if the system loader is unable to resolve the hard dependency on HWLOC for
~tbbbind~. In this case, the HW topology is not discovered and the machine is
seen as if all CPU cores were uniform, which is the default TBB behavior when
NUMA constraints are not used. Thus, the following code returns the values that
do not reflect the real topology and do not matter:

#+begin_src C++
std::vector<oneapi::tbb::numa_node_id> numa_nodes = oneapi::tbb::info::numa_nodes();
std::vector<oneapi::tbb::core_type_id> core_types = oneapi::tbb::info::core_types();
#+end_src

This lack of valid HW topology data due to absence of a third party library is
the major problem with the current oneTBB behavior. There is no diagnostics for
the issue, which likely makes it unnoticeable by developers, and the code that
uses oneTBB NUMA support facilities continues running but does not use NUMA as
intended.

Having a dependency on a shared HWLOC library has advantages:
1. Code reuse with all of the positive consequences out of this, including
relying on the same code that has been tested and debugged, allowing the OS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but in fact most of Linux OSes has obsolete hwloc versions and relying on it does not provide benefits.
IMO, having most up-to-date static HWLOC together with recent versions of oneTBB has benefits and fixes / new features are available to oneTBB immediately

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did not know that. I will consider this in the future changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rewrite it to smth like this:
1. Reliability. Using a tested and debugged shared library, oneTBB benefits from established, reliable functionality.
2. Code Reuse. Reuse the same code across different processes, improving cache locality and reducing memory footprint, which is the primary purpose of shared libraries.
3. Drop-In Replacement. Use your version of HWLOC without recompiling oneTBB. It can be useful in the following cases:

  • You need to apply a hotfix to support your hardware that has not yet been integrated into the HWLOC project.
  • You use a HWLOC version that may never be upstreamed. For example, if hardware unavailable to the broader market.
  • You want to test a development version of HWLOC on your system.

to share it among different processes, which consequently improves on cache
locality and memory footprint. That's the primary purpose of shared
libraries.
2. A drop-in replacement. Users are able to use their own version of HWLOC
without recompilation of oneTBB. This specific version of HWLOC could include
a hotfix to support a particular and/or new hardware that a customer has, but
whose support is not yet upstreamed to HWLOC project. It is also possible
that such support won't be upstreamed at all if that hardware is not going to
be available for massive users. It could also be a development version of
HWLOC that someone wants to test on their systems first. Of course, they can
do it with the static version as well, but that's more cumbersome as it
requires recompilation of every dependent component.

The only disadvantage from depending on HWLOC library dynamically is that the
developers that use oneTBB's NUMA support API need to make sure the library is
available and can be found by oneTBB. Depending on the distribution model of a
developer's code, this is achieved either by:
1. Asking the end user to have necessary version of a dependency pre-installed.
2. Bundling necessary HWLOC version together with other pieces of a product
release.

However, the requirement to fulfill one of the above steps for the NUMA API to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the need to complete one of the above steps for the NUMA API to function effectively may be seen as inconvenient. More importantly, it is not always immediately clear that these steps are required. Especially, die to the silent fallback behavior when the HWLOC library is not found in the environment.

start paying off may be considered as an incovenience and, what is more
important, it is not always obvious that one of these steps is needed.
Especially, due to silent behavior in case HWLOC library cannot be found in the
environment.

This proposal suggests an improvement to reduce the effect of the disadvantage
being dependent on a dynamic version of HWLOC library by having it linked
statically with one of the ~tbbbind~ libraries that are distributed together
with oneTBB, yet leaving possibility to specify another version of HWLOC library
if users see the need.

Since HWLOC 1.x is an old version of HWLOC and modern versions of operating
systems install HWLOC 2.x by default, the probability of someone who is
constrained by using only HWLOC 1.x on their system is relatively small. Thus,
the filename of the ~tbbbind~ library that is linked against HWLOC 1.x can be
re-used for the library that is linked against static HWLOC version 2.x.

* Proposal
1. Replace the dynamic link of ~tbbbind~ library which is currently linked
against HWLOC 1.x with the link to a static HWLOC library version 2.x.
2. Add loading of that ~tbbbind~ variant as the last attempt to resolve the
dependency on functionality provided by ~tbbbind~ layer.
3. Update the oneTBB documentation considering [[https://oneapi-src.github.io/oneTBB/search.html?q=tbb%3A%3Ainfo][these documentation pages]] to
include steps determining the variant of ~tbbbind~ being used.

** Advantages
1. The proposed behavior allows having a mechanism for resolving a dependency on
HWLOC library in case it cannot be found in the environment, while still
preferring user-provided version of HWLOC. As a result, the problematic use of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
preferring user-provided version of HWLOC. As a result, the problematic use of
preferring user-provided versions. As a result, the problematic oneTBB API usage

oneTBB API mentioned above should work as expected, returning enumerated list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
oneTBB API mentioned above should work as expected, returning enumerated list
works as expected, returning an enumerated list

of actual NUMA nodes and core types on the system the code is running on,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of actual NUMA nodes and core types, provided that:

  • The loaded HWLOC library is compatible with the system.
  • The application properly distributes all oneTBB binaries and configures the environment to locate and load the required tbbbind library variant.

provided that the loaded HWLOC library works on that system and that an
application properly distributes all binaries of oneTBB, sets the environment
so that the necessary variant of ~tbbbind~ library can be found and loaded.
2. The drop of support for HWLOC 1.x allows to not introducing additional
~tbbbind~ variant of the library, yet maintaining support for popular
versions of HWLOC.

** Disadvantages
By default still no diagnostics if users failed to setup environment with their
own version of HWLOC library correctly. Although, specifying ~TBB_VERSION=1~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
own version of HWLOC library correctly. Although, specifying ~TBB_VERSION=1~
version of HWLOC. Although, specifying the ~TBB_VERSION=1~

envar will help identifying an issue with setup of environment pretty quickly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
envar will help identifying an issue with setup of environment pretty quickly.
environment variable helps identify configuration issues quickly.


* Alternative handling of inability to parse system topology
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Alternative handling of inability to parse system topology
* Alternative Handling for Missing System Topology

The other behavior in case HWLOC library cannot be found is to be more explicit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative approach to handle the absence of the HWLOC library is to adopt a more explicit response:

  • Issue a warning about the missing component.
  • Require one of the tbbbind variants to be loaded by refusing to work or throwing an exception.

about the problem of a missing component and to either issue a warning or to
refuse working requiring one of the ~tbbbind~ variant to be loaded (e.g., throw
an exception).

Comparing these alternative approaches to the one proposed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a heading?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No necessarily.

** Common Advantages
- Explicitly tells that the functionality being used is not going to work
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Explicitly tells that the functionality being used is not going to work
- Explicitly indicates that the functionality being used does not work,

instead of just being silent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
instead of just being silent.
instead of failing silently.

- Does not require additional variant of ~tbbbind~ library to be distributed
along with the others.

** Common Disadvantages
- Requires additional step from the user side to resolve the problem. In other
words, it does not provide complete solution to the problem.

** Disadvantages of Issuing a Warning
- The warning may still not be visible, especially if standard streams are
closed.

** Disadvantages of Throwing an Exception
- May break existing code as it does not expect an exception to be thrown.
- Requires introduction of an additional exception hierarchy.

* References
1. [[https://www.open-mpi.org/projects/hwloc/][HWLOC project main page]]
2. [[https://github.com/open-mpi/hwloc][HWLOC project repository on GitHub]]