Fix bug: focus was not restored after closing lightbox. #4838
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crhallberg
approved these changes
Nov 10, 2025
Contributor
crhallberg
left a comment
crhallberg
left a comment
There was a problem hiding this comment.
Confirmed that the stealing of the focus is not coming from inside the house.
EreMaijala
pushed a commit
to NatLibFi/NDL-VuFind2
that referenced
this pull request
Nov 12, 2025
) (cherry picked from commit addb534)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported on vufind-tech that keyboard focus did not restore correctly after closing the lightbox. It appears to be related to bootstrap event behavior; moving the focus restoration to a later stage of the process seems to have solved the issue. Thanks to @crhallberg for help figuring this out!