Skip to content

Conversation

@SebastianBurke
Copy link
Contributor

@SebastianBurke SebastianBurke commented Aug 1, 2024

Simple example pages with corresponding component references for the following components:
ajax-fetch
json-fetch
navcurrent
resize
wb-focus

Also a minor fix for the geomap index.json-ld file where an english example page had a language value of "fr"

Copy link
Collaborator

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianBurke

  • Fix the URLs to the example pages for Navcurrent and Resize (make sure the language toggle also works)
  • Remove the class "list-inline" from the list of events and list of components. It is not necessary

@SebastianBurke
Copy link
Contributor Author

Made the changes @Garneauma
I am unsure if I made all the changes you requested to Navcurrent and resize - please confirm, thanks!

@Garneauma
Copy link
Collaborator

Pre-approved upon successful review.

Copy link
Collaborator

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rename folder "navcurrent" to "wb-navcurr"
  • Rename folder "resize" to "wb-rsz"
  • Address inline comments
  • Rebase PR to fix merge conflict

@Garneauma Garneauma merged commit 2f0e017 into wet-boew:master Oct 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants