WET-484 Rotating features for Home and News #2424

Ricokola · 2024-09-16T18:21:44Z

No description provided.

duboisp

My review is incomplete. Please do all the cleanup/update and use only supported component/pattern.

templates/home/home-en.html

templates/news/deprecated/news_v2-en.html

Garneauma · 2024-09-23T14:05:04Z

Pre-approved upon successful review.

duboisp

I did a partial review. I will continue tomorrow.

I only quickly reviewed the html of the working example. I didn't tested the working example neither looked at the documentation.

templates/assets/home-feature-1-520x200.jpg

templates/home/home-en.html

templates/home/home-fr.html

templates/news/news-en.html

duboisp

Here some comment, I am looking at the documentation now.

templates/news/news-en.html

duboisp

See the inline comment

templates/home/api-en.html

templates/home/api-fr.html

templates/news/news-en.html

templates/home/api-en.html

templates/home/api-fr.html

templates/news/news-doc-en.html

duboisp · 2024-10-07T21:45:36Z

Review and tested locally. The working example page looks good.

duboisp

Reviewed and tested locally.

Look good to merge.

duboisp · 2024-10-08T13:22:18Z

Note: This change is a Patch change

duboisp

See my inline comments

templates/news/news-en.html

templates/news/news-fr.html

Garneauma · 2024-10-09T17:34:27Z

@duboisp Thank you for the suggestions. It is much better that way.

duboisp

Reviewed and tested locally

It looks good.

This is a patch change.

Ricokola requested review from Garneauma and duboisp September 16, 2024 18:22

Ricokola had a problem deploying to github-ci September 16, 2024 18:22 — with GitHub Actions Failure

Ricokola force-pushed the wet-484 branch from 08e6884 to 4f5d53a Compare September 16, 2024 19:18

Ricokola temporarily deployed to github-ci September 16, 2024 19:18 — with GitHub Actions Inactive

duboisp requested changes Sep 18, 2024

View reviewed changes

templates/home/home-en.html Outdated Show resolved Hide resolved

templates/home/home-en.html Outdated Show resolved Hide resolved

duboisp requested changes Sep 18, 2024

View reviewed changes

templates/home/home-en.html Outdated Show resolved Hide resolved

Ricokola force-pushed the wet-484 branch from 4f5d53a to a71cf53 Compare September 19, 2024 11:43

Ricokola temporarily deployed to github-ci September 19, 2024 11:43 — with GitHub Actions Inactive

duboisp requested changes Sep 19, 2024

View reviewed changes

Garneauma had a problem deploying to github-ci September 23, 2024 16:09 — with GitHub Actions Failure

Garneauma force-pushed the wet-484 branch from fc389f4 to e4756a8 Compare September 23, 2024 16:27

Garneauma temporarily deployed to github-ci September 23, 2024 16:27 — with GitHub Actions Inactive

Garneauma requested review from duboisp and removed request for Garneauma September 23, 2024 17:26

Garneauma force-pushed the wet-484 branch from e4756a8 to beded7f Compare September 25, 2024 17:33

Garneauma temporarily deployed to github-ci September 25, 2024 17:33 — with GitHub Actions Inactive

duboisp requested changes Sep 26, 2024

View reviewed changes

Garneauma force-pushed the wet-484 branch from beded7f to a905228 Compare September 26, 2024 12:48

Garneauma temporarily deployed to github-ci September 26, 2024 12:49 — with GitHub Actions Inactive

Garneauma force-pushed the wet-484 branch from a905228 to 2f2eb9e Compare September 26, 2024 12:51

Garneauma temporarily deployed to github-ci September 26, 2024 12:51 — with GitHub Actions Inactive

duboisp self-assigned this Oct 1, 2024

duboisp requested changes Oct 3, 2024

View reviewed changes

templates/news/news-en.html Outdated Show resolved Hide resolved

templates/news/news-en.html Outdated Show resolved Hide resolved

templates/news/news-en.html Outdated Show resolved Hide resolved

Garneauma force-pushed the wet-484 branch from 2f2eb9e to 7e535dd Compare October 4, 2024 13:19

Garneauma temporarily deployed to github-ci October 4, 2024 13:20 — with GitHub Actions Inactive

duboisp requested changes Oct 4, 2024

View reviewed changes

templates/news/news-en.html Outdated Show resolved Hide resolved

WET-484 Rotating features for Home and News

36615c9

Garneauma force-pushed the wet-484 branch from 7e535dd to 873ba50 Compare October 7, 2024 17:34

Garneauma temporarily deployed to github-ci October 7, 2024 17:34 — with GitHub Actions Inactive

Garneauma force-pushed the wet-484 branch from 873ba50 to 95b01ea Compare October 7, 2024 18:06

Garneauma temporarily deployed to github-ci October 7, 2024 18:07 — with GitHub Actions Inactive

Garneauma force-pushed the wet-484 branch from 95b01ea to eeea11f Compare October 7, 2024 18:29

Garneauma temporarily deployed to github-ci October 7, 2024 18:29 — with GitHub Actions Inactive

Garneauma force-pushed the wet-484 branch from eeea11f to 40a3df7 Compare October 7, 2024 18:38

Garneauma temporarily deployed to github-ci October 7, 2024 18:38 — with GitHub Actions Inactive

duboisp requested changes Oct 7, 2024

View reviewed changes

Garneauma force-pushed the wet-484 branch from 40a3df7 to 4736bc2 Compare October 8, 2024 12:29

Garneauma temporarily deployed to github-ci October 8, 2024 12:29 — with GitHub Actions Inactive

duboisp previously approved these changes Oct 8, 2024

View reviewed changes

Garneauma dismissed duboisp’s stale review via b0982a4 October 9, 2024 12:36

Garneauma force-pushed the wet-484 branch from 4736bc2 to b0982a4 Compare October 9, 2024 12:36

Garneauma temporarily deployed to github-ci October 9, 2024 12:37 — with GitHub Actions Inactive

Garneauma force-pushed the wet-484 branch from b0982a4 to 712a312 Compare October 9, 2024 16:01

Garneauma temporarily deployed to github-ci October 9, 2024 16:01 — with GitHub Actions Inactive

duboisp requested changes Oct 9, 2024

View reviewed changes

templates/news/news-en.html Outdated Show resolved Hide resolved

templates/news/news-en.html Outdated Show resolved Hide resolved

templates/news/news-fr.html Outdated Show resolved Hide resolved

News and Home templates: randomizing features

e4b7bac

Garneauma force-pushed the wet-484 branch from 712a312 to e4b7bac Compare October 9, 2024 17:34

Garneauma temporarily deployed to github-ci October 9, 2024 17:34 — with GitHub Actions Inactive

duboisp approved these changes Oct 9, 2024

View reviewed changes

Garneauma merged commit 8a4fcc1 into wet-boew:master Oct 15, 2024
1 check passed

Garneauma added this to the v15.7.0 milestone Oct 15, 2024

Ricokola deleted the wet-484 branch September 16, 2025 11:47

WET-484 Rotating features for Home and News #2424

WET-484 Rotating features for Home and News #2424

Uh oh!

Conversation

Ricokola commented Sep 16, 2024

Uh oh!

duboisp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Garneauma commented Sep 23, 2024

Uh oh!

duboisp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

duboisp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

duboisp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

duboisp commented Oct 7, 2024

Uh oh!

duboisp left a comment

Choose a reason for hiding this comment

Uh oh!

duboisp commented Oct 8, 2024

Uh oh!

duboisp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Garneauma commented Oct 9, 2024

Uh oh!

duboisp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants