-
Notifications
You must be signed in to change notification settings - Fork 140
ci: copy split up CI jobs from upstream #2525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nschonni
wants to merge
8
commits into
wet-boew:master
Choose a base branch
from
nschonni:ci-jobs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5364ab7
ci: add separate job for JSON linting
nschonni 84baa11
ci: add separate job for HTML linting
nschonni bda285f
ci: add separate job for Spaces linting
nschonni 28f0d28
ci: update core CI job to use actions/checkout
nschonni 8de0110
wip: updated HTML Proofer path
nschonni 3e85067
chore: Remove Bower from scripts
nschonni 216d6b7
fix: remove commented out liquid tag
nschonni 193b6ce
wip: copy page build from pages job
nschonni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| name: HTML Linting | ||
| on: | ||
| push: | ||
| branches-ignore: | ||
| - "dependabot/**" | ||
| paths: | ||
| - "package*.json" | ||
| - "Gruntfile.coffee" | ||
| - "Rakefile" | ||
| - "**/*.hbs" | ||
| - "**/*.html" | ||
| - ".github/workflows/lint-html.yml" | ||
|
|
||
| pull_request: | ||
| paths: | ||
| - "package*.json" | ||
| - "Gruntfile.coffee" | ||
| - "Rakefile" | ||
| - "**/*.hbs" | ||
| - "**/*.html" | ||
| - ".github/workflows/lint-html.yml" | ||
|
|
||
| jobs: | ||
| lint-html: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Clone repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up JDK | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: 8 | ||
| distribution: "temurin" | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| bundler-cache: true | ||
| ruby-version: "3.3" | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| cache: npm | ||
|
|
||
| - name: Install Grunt | ||
| run: npm i -g grunt-cli --force | ||
|
|
||
| - name: Install npm dependencies | ||
| run: npm ci | ||
|
|
||
| # Related to GCWeb#1737 about wet-boew#cc340a6 commit | ||
| - name: Copy the missing _sprite_share.scss file | ||
| run: | | ||
| curl https://gist.githubusercontent.com/duboisp/d69787b300eb1f4d40f937508e10d013/raw/86e7a0b15ad6a695754599e9793e986b460bf514/_sprites_share.scss >> _sprites_share.scss | ||
| mv _sprites_share.scss node_modules/wet-boew/src/plugins/share/sprites/_sprites_share.scss | ||
|
|
||
| - name: Build GCWeb | ||
| run: grunt build-gh-pages | ||
|
|
||
| # Overwrite all layout and includes and remove dist from .gitignore | ||
| - name: Update GCWeb Jekyll theme files | ||
| run: | | ||
| cp -R ~jekyll-dist/_includes/* _includes/ | ||
| cp -R ~jekyll-dist/_layouts/* _layouts/ | ||
|
|
||
| - name: Setup Pages | ||
| id: pages | ||
| uses: actions/configure-pages@v5 | ||
|
|
||
| # Generate all the Jekyll files and push to ./_site | ||
| - name: Build with Jekyll | ||
| run: bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path }}" | ||
| env: | ||
| JEKYLL_ENV: production | ||
| - name: HTMLlint | ||
| run: grunt htmllint | ||
|
|
||
| - name: HTMLProofer | ||
| run: bundle exec rake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: JSON Linting | ||
| on: | ||
| push: | ||
| branches-ignore: | ||
| - "dependabot/**" | ||
| paths: | ||
| - "Gruntfile.coffee" | ||
| - "**/*.json" | ||
| - "**/*.json-ld" | ||
| - ".github/workflows/lint-json.yml" | ||
|
|
||
| pull_request: | ||
| paths: | ||
| - "Gruntfile.coffee" | ||
| - "**/*.json" | ||
| - "**/*.json-ld" | ||
| - ".github/workflows/lint-json.yml" | ||
|
|
||
| jobs: | ||
| lint-js: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Clone repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| cache: npm | ||
|
|
||
| - name: Install Grunt | ||
| run: npm i -g grunt-cli --force | ||
|
|
||
| - name: Install npm dependencies | ||
| run: npm ci --ignore-scripts | ||
|
|
||
| - name: JSONLint | ||
| run: grunt jsonlint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: Space Linting | ||
| on: | ||
| push: | ||
| branches-ignore: | ||
| - "dependabot/**" | ||
| paths: | ||
| - "**" | ||
| - "!**/*.{ico,jpg,png}" | ||
| - "!**/*.{eot,svg,ttf,woff}" | ||
| - ".github/workflows/lint-spaces.yml" | ||
|
|
||
| pull_request: | ||
| paths: | ||
| - "**" | ||
| - "!**/*.{ico,jpg,png}" | ||
| - "!**/*.{eot,svg,ttf,woff}" | ||
| - ".github/workflows/lint-spaces.yml" | ||
|
|
||
| jobs: | ||
| lint-spaces: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Clone repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| cache: npm | ||
|
|
||
| - name: Install Grunt | ||
| run: npm i -g grunt-cli --force | ||
|
|
||
| - name: Install npm dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Lintspaces | ||
| run: grunt lintspaces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| #!/bin/sh | ||
| npm install -g bower grunt-cli && npm install | ||
| npm install -g grunt-cli && npm install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| npm install -g bower grunt-cli && npm install | ||
| npm install -g grunt-cli && npm install |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the condition it doesn't look like this is currently being run. Maybe better to just remove the change or this step