build: expand lintspaces globs #2529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pre-approved upon successful review. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Garneauma
requested changes
Jun 5, 2025
Collaborator
Garneauma
left a comment
Garneauma
left a comment
There was a problem hiding this comment.
Please exclude files under the "_data/" directory. They are autogenerated, so they will always fail if they failed during your testing.
Member
Author
|
I'll see if there is an override I can make to https://github.com/wet-boew/GCWeb/blob/master/.editorconfig so it passes without the changes, but doesn't require ignoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request(PR) do?
Expand the lintspaces globs and fix the new issues. Temporarily ignored MD and JS files, since they'll be handled by existing PRs, then can be opt'd in again
Contribution category (please only choose one)
General checklist
Related issues