Redirecting to page with a phlex view not redrawing the page

[janpeterka]

Disclaimer: I already found out the solution, but I don't really understand what was happening, and also want to help if someone stumbles on the some.

So, I started using Phlex (+ RubyUI) in my new project for the first time. I needed to move fast, so I used Phlex where comfortable and still kept some "classic" views around (generated layout, all form pages).

I noticed that some actions do not rewrite the page, only changing parts or appending some HTML to the page (weirdly, at least once it appended after the .

At last I found out the problem was that I was using render Views::Dashboard::Show and not render Views::Dashboard::Show.new in my controller.

Why is that? And would it be worth it to add some warning somewhere?

Thanks!

[joeldrapper]

When you render the class without .new, it should be the same as if you had called .new and passed no arguments.

[janpeterka]

I thought it should, but it doesn't seem so. I'll try to provide more info, as this seems as possible bug or misconfiguration.

[robgough]

I'd like to add that I've just experienced exactly this issue, thought I was going mad. I have an almost brand new rails app, with the rails generated authentication, and was in the process of swapping out to Phlex views (including the Layout as per the docs).

/sessions/new was rendered ok, but after a successful submit when it should redirect to the root_url it was instead appending the whole view (including layout again). On the controller for the root_url (Main#Home) I had only called render Views::Main::Home missing off the .new. Adding .new fixed the issue and the view was replaced correctly on submit.

[joeldrapper]

Can you try adding this to the end of your phlex.rb initializer and see if it fixes it?

class Phlex::HTML
  def self.format = :html
end

My suspicion is that Rails calls format on the renderable and assumes it’s a turbo response if it doesn’t return :html. We define format on the Phlex::HTML instance but not the class. That would explain why you’d get this behaviour even though render_in on the class delegates to render_in on a new instance.

[robgough]

Just tested, and that does seem to work – thanks!

[joeldrapper]

Okay, we’ll add that to Phlex-Rails. Thanks for checking it. 🙏🏻

[joeldrapper]

I just pushed a commit which should fix this. It will be in the next version of phlex-rails. In the meantime, use .new or this workaround.