Increase waRed contrast with EC floor when higher_contrast set #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When higher_contrast is set, change the waRed[123] walls to be green-ish instead of purple-ish in Eclectic City, for greater contrast with EC's purple-ish floor.
The logic for selecting waRed's colors is strange, and this delta is from me futzing around with the code until I got it to look decent, instead of getting an understanding of the waRed color logic and applying that knowledge. I expected the motivation behind the complicated waRed color behavior to be making the floor:wall color relationships match those of RRV. But this seems refuted by observing that RRV and CR1 have nearly identical floor colors yet waRed appears very differently in them.