-
Notifications
You must be signed in to change notification settings - Fork 99
macOS: switch to png for image #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3203d92 to
c283f81
Compare
|
Hey there, thanks for the PR. Similar to the first PR which tried this, can I ask that you do some basic compatibility testing to make sure this doesn't regress any major use cases? Some examples would be:
|
|
Unfortunately at the moment I don't have access to an Apple device. |
|
I'm marking this one with both |
|
I spent some time testing this today and my conclusion is that I believe we will need to continue to support TIFF on Apple platforms in order to retain compatibility with pasting images from Apple's own apps. In my testing I used Chrome, Firefox, Screenshot tool, and a bunch of Electron apps. All of these had no issues with providing data in a PNG format. However when I tried pasting an image supplied by I did try a different approach (getting a bitmap of RGBA from
|
Used png for handling images on all platform. On macOS dropped the dependency on core-graphics since now an image is directly stored as png