-
Notifications
You must be signed in to change notification settings - Fork 72
E2E: Fixed addSavedCard and Rate Limit adding card too soon with 3DS cards #11024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 870 kB ℹ️ View Unchanged
|
…ew payment method` as it can take time to process before it's really added on the back-end
|
🎉
25 minutes! Much faster now, comparing with the previous scheduled ones https://github.com/Automattic/woocommerce-payments/actions/workflows/e2e-test.yml |
dmvrtx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense and are a nice improvement!
Fixes WOOPMNT-5286
Changes proposed in this Pull Request
Changes in this PR basically following
selectPaymentMethodimprovements in Fix e2e failures with WC 7.7.0 #10994woocommerce-payments/tests/e2e/utils/shopper.ts
Lines 337 to 346 in 40929bb
Another change is to move
markCardAddedafter confirming that the card is really added to the back-end. This is to fix the issueYou cannot add a new payment method so soon after the previous one. Please try again later.like this:Testing instructions
E2E Tests - Allhttps://github.com/Automattic/woocommerce-payments/actions/runs/17320043970E2E Tests on Atomic - Allhttps://github.com/Automattic/woocommerce-payments/actions/runs/17320054976npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.