-
Notifications
You must be signed in to change notification settings - Fork 72
[E2E] [QIT] Migrate shopper e2e specs #11069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+4,967
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Contributor
|
Size Change: 0 B Total Size: 873 kB ℹ️ View Unchanged
|
6 tasks
- Introduced WP-CLI commands for QIT setup and status checks to assist in development environments. - Created a new class `WP_CLI_QIT_Dev_Command` for handling Jetpack connection setup and account data refresh. - Added E2E test runner script and configuration for QIT, including basic tests for WooCommerce Payments functionality. - Updated package.json to include a new script for running QIT E2E tests. - Enhanced default environment configuration for QIT testing with necessary credentials. - Implemented setup script for WooCommerce Payments E2E tests to configure products, customers, and Jetpack connections. - Added ESLint configuration for E2E tests to accommodate Playwright testing framework. - Created initial E2E test cases to verify basic functionality and plugin activation.
…nce setup functions, and add connection validation tests
- Add .github/workflows/qit-e2e.yml with comprehensive CI setup - Support multiple WooCommerce and PHP version combinations - Enable manual workflow dispatch with custom parameters - Update e2e-runner.sh to handle CI environment options - Add CI.md documentation explaining workflow usage and setup The workflow runs on PR, push to main branches, scheduled, and manual dispatch. Includes proper authentication and environment variable handling for CI context.
Security improvements: - Add GitHub Actions log masking for all sensitive tokens - Use environment variables instead of command-line arguments in WP-CLI - Update WP_CLI_QIT_Dev_Command to prioritize env vars over CLI args - Remove tokens from command-line to prevent exposure in process lists - Add comprehensive security documentation and best practices This prevents token leakage through: - Process lists (ps aux) - Command history - GitHub Actions logs - Error output and debugging info All tests continue to pass with enhanced security measures.
…tagging for WooCommerce Blocks tests
e16aa7e to
57b077c
Compare
Contributor
Author
|
Closing this PR in favor of smaller chunks to facilitate reviews, starting with #11133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #WOOPMNT-5344
This PR is part of a larger effort to migrate WooPayments E2E tests to the QIT (Quality Insights Toolkit) stack. The work is split into stacked PRs for easier review.
Changes proposed in this Pull Request
SKIP_WC_BLOCKS_TESTS) from 4 WooCommerce Blocks specs in favor of tag-based filteringSkip Flags Removal
What Changed:
Benefits:
--tag=@blocksor--skip-tag=@blocksat runtimeSKIP_WC_BLOCKS_TESTS=1Note: I started the shopper migration in this branch, but had to discard the approach.
Testing instructions
Run ALL tests:
Use
npm run test:qit-e2eto run all the specs. Note: Theshopper-myaccount-saved-cards.spec.tsusually fails when not running in isolation, this needs more investigation so I created this issue to look into it separately, since the current goal is to migrate the tests.Run a single spec (multiple formats work):
Full path from project root
npm run test:qit-e2e -- tests/qit/e2e/specs/woopayments/shopper/shopper-checkout-purchase.spec.tsJust the filename (it will search for it)
npm run test:qit-e2e -- shopper-checkout-purchase.spec.tsPartial path
npm run test:qit-e2e -- e2e/specs/woopayments/shopper/shopper-checkout-purchase.spec.tsRun tests by tag:
Run all shopper tests
npm run test:qit-e2e -- --tag=shopperRun all critical tests
npm run test:qit-e2e -- --tag=criticalRun all WC blocks tests
npm run test:qit-e2e -- --tag=blocksCombine tag with specific directory:
Run critical shopper tests only
npm run test:qit-e2e -- tests/qit/e2e/specs/woopayments/shopper --tag=criticalnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge