Enforce strict user capability checks when deleting test orders #11122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Contributor
|
Size Change: 0 B Total Size: 873 kB ℹ️ View Unchanged
|
elazzabi
approved these changes
Nov 5, 2025
Member
elazzabi
left a comment
elazzabi
left a comment
There was a problem hiding this comment.
Better safe than sorry. Good addition 
dmallory42
approved these changes
Nov 5, 2025
Contributor
dmallory42
left a comment
dmallory42
left a comment
There was a problem hiding this comment.
Looks good to me. Change makes sense and works as expected, thanks for adding this!
vladolaru
deleted the
update/verify-user-access-when-deleting-test-orders
branch
vladolaru
added a commit
that referenced
this pull request
Nov 5, 2025
Contributor
Author
|
This PR was cherry-picked into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11103
Changes proposed in this Pull Request
Better safe than sorry: even if the WooCommerce Debug Tools have access checks, we should make sure we have backstops in place. When deleting test orders we add an explicit check for the
manage_woocommercecapability.Also, we were missing the right parameter to force delete test orders and skip trash.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge