feat: Add cloud E2E testing infrastructure #6625
Draft
+501
−241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Playwright tests for cloud environment with Firebase auth. Changes: - Refactor ComfyPage to abstract base class - Add LocalhostComfyPage (existing devtools implementation) - Add CloudComfyPage (cloud settings API, Firebase auth) - Add cloud fixture with auth state persistence - Add globalSetupCloud for Firebase login - Add playwright.cloud.config with 5x timeout - Add basic cloud tests (load app, canvas interaction, settings) - Update .gitignore for auth state files - Update tsconfig to include playwright.cloud.config Architecture: - ComfyPage abstract with 3 backend-specific methods - LocalhostComfyPage uses /api/devtools + multi-user - CloudComfyPage uses /api/settings + Firebase localStorage - No code duplication (95% shared) Setup: - Requires CLOUD_TEST_EMAIL and CLOUD_TEST_PASSWORD env vars - globalSetup logs in once, saves auth to browser_tests/.auth/ - Tests reuse saved auth state (no login per test)
dosubot
bot
added
the
size:L
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/13/2025, 06:00:14 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 11/13/2025, 06:12:20 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 2.93 MB (baseline 2.93 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 799 kB (baseline 799 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 8 kB (baseline 8 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 306 kB (baseline 306 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 266 kB (baseline 266 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 5.87 kB (baseline 5.87 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.92 MB (baseline 3.92 MB) • ⚪ 0 BBundles that do not match a named category
|
Fixes circular dependency between ComfyPage and LocalhostComfyPage. Changes: - Create browser_tests/fixtures/comfyPageFixture.ts with fixture - Remove fixture from ComfyPage.ts (keep abstract class only) - Re-export fixture from ComfyPage.ts for backward compatibility Now properly follows dependency hierarchy: - ComfyPage.ts (abstract) - no implementation imports - LocalhostComfyPage.ts → imports ComfyPage - comfyPageFixture.ts → imports both - Tests import from ComfyPage.ts (re-exported)
Circular dependency was caused by: - comfyPageFixture.ts importing testComfySnapToGridGridSize from ComfyPage.ts - ComfyPage.ts re-exporting comfyPageFixture Solution: - Extract testComfySnapToGridGridSize to constants.ts - Both files import from constants.ts - Only type-import ComfyPage in comfyPageFixture.ts Now clean dependency graph with no cycles.
- Remove comfyPageFixture re-export from ComfyPage.ts - Update all test imports to use comfyPageFixture from its own file - Update README.md example to show correct import path - Fixes: comfyPageFixture → LocalhostComfyPage → ComfyPage circular import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Playwright tests for cloud with Firebase auth.
Changes
Setup
Requires env vars:
Run
Goal
Validate approach before expanding coverage or adding CI.
┆Issue is synchronized with this Notion page by Unito