Skip to content

Conversation

@shangyian
Copy link
Contributor

Summary

For metrics SQL generation, we should COALESCE the selected expressions after doing a FULL OUTER JOIN on the shared dimensions of the metrics. This is because the intention of the FULL JOIN is to be able to bring in all possible dimension values, and not coalescing means that we miss out on cases with null values for one set of metrics, but non-null values for a different set of metrics.

Test Plan

Locally + unit tests

Deployment Plan

@netlify
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit 63d2b1f
🔍 Latest deploy log https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/6717b99ad91c7b0008359e44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant