feat: modal add modalRender prop #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd00284:
|
Collaborator
|
本次 beta 版本更不上，提交的 feat 会在下个 beta 版本前 review， fix 相关会在下个正式版本前处理 |
Contributor
Author
|
@YyumeiZhang @pointhalo 能否抽空 review 下我的 PR？目前 CI 中的报错应该不是我的 PR 引起的，我并没有变更依赖，我该如何解决。 |
Collaborator
CI 中的报错可能和你是非组织用户有关系，你可以不用处理。 fix 的 PR #2773， #2778 已经 review 并合入，Feat 的 PR 在下一个 beta 版本的时候做下处理 |
Contributor
Author
|
@YyumeiZhang 打扰了，能辛苦 review 下我的两个 Feat PR 嘛。 |
YyumeiZhang
approved these changes
Jun 9, 2025
semi-design
|
||||||||||||||||||||||||||||||
| Project |
semi-design
|
| Branch Review |
release
|
| Run status |
|
| Run duration | 08m 14s |
| Commit |
|
| Committer | LonelySnowman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
13
|
Skipped
|
0
|
Passing
|
286
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
Fixes #2655
Changelog
🇨🇳 Chinese
🇺🇸 English
Checklist
Other
Additional information