Skip to content

Change EditingStack from StateObject to regular variable #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change EditingStack from StateObject to regular variable #276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c06d40
Change editingStack from StateObject to regular var
oootkarsh Sep 29, 2025
01c44ba
Removed the _ since editingStack is not a StateObject anymore.
oootkarsh Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/BrightroomUIPhotosCrop/PhotosCropRotating/PhotosCropRotating.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public struct PhotosCropRotating: View {
}
}

@StateObject var editingStack: EditingStack
var editingStack: EditingStack

@State private var rotation: EditingCrop.Rotation?
@State private var adjustmentAngle: EditingCrop.AdjustmentAngle?
Expand All @@ -67,7 +67,7 @@ public struct PhotosCropRotating: View {
public init(
editingStack: @escaping () -> EditingStack
) {
self._editingStack = .init(wrappedValue: editingStack())
self.editingStack = editingStack()
}

private var isLoading: Bool {
Expand Down