Clean up defunct shaka-player types patching #8224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Nov 3, 2025
PikachuEXE
approved these changes
Nov 4, 2025
Collaborator
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Took me a while to find the PR
shaka-project/shaka-player#9243
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 4, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 6, 2025
* development: Change clear filter button from text to icon (FreeTubeApp#8205) Feat clickable playlist progress bar (FreeTubeApp#7782) Add Hide channels based on text (FreeTubeApp#7948) Clean up defunct shaka-player types patching (FreeTubeApp#8224)
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 6, 2025
* development: Change clear filter button from text to icon (FreeTubeApp#8205) Feat clickable playlist progress bar (FreeTubeApp#7782) Add Hide channels based on text (FreeTubeApp#7948) Clean up defunct shaka-player types patching (FreeTubeApp#8224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Description
With version 4.16.7 shaka-player started shipping with the TypeScript types exported by default, which means we no longer need that part of our patching script.
Testing
N/A
Desktop