Fix login component #12
Open
+67
−601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commented out some parts but reordered some things to flow better in example readme
ran into a minor bug where user could login without filling out anything and led to ugly looking error page *sort of* mitigates it, clean up duplicated `Astro.props`, and uses classes like this: https://docs.astro.build/en/guides/styling/#passing-a-class-to-a-child-component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a teeny issue with the
<Login /component where user could hit submit with an empty field and they'd be taken to an ugly error page.I haven't mitigated this entirely, but I set the input field with
requiredattribute and addedautocomplete="username"so people could use autocomplete with their ATProto handles. Went ahead and cleaned up some duplicateAstro.propswhile I was at it.Edit: o..... I. Uh. I didn't mean for my other commits to show up in this PR.... my bad